From 8ec2d93a4fc77d6539ca83fb53d53ca26735088c Mon Sep 17 00:00:00 2001 From: Simon McVittie Date: Mon, 15 Jan 2018 15:15:52 +0000 Subject: [PATCH 2/4] bus: Notify systemd when we are ready Signed-off-by: Simon McVittie --- bus/bus.c | 2 ++ bus/dbus.service.in | 1 + bus/systemd-user/dbus.service.in | 1 + dbus/dbus-sysdeps-util-unix.c | 12 ++++++++++++ dbus/dbus-sysdeps-util-win.c | 5 +++++ dbus/dbus-sysdeps.h | 2 ++ 6 files changed, 23 insertions(+) diff --git a/bus/bus.c b/bus/bus.c index a6f8db47..134d7e1e 100644 --- a/bus/bus.c +++ b/bus/bus.c @@ -1025,6 +1025,8 @@ bus_context_new (const DBusString *config_file, goto failed; } + _dbus_daemon_report_ready (); + if (parser != NULL) { bus_config_parser_unref (parser); diff --git a/bus/dbus.service.in b/bus/dbus.service.in index ca0b7e96..3db9b0b1 100644 --- a/bus/dbus.service.in +++ b/bus/dbus.service.in @@ -4,6 +4,7 @@ Documentation=man:dbus-daemon(1) Requires=dbus.socket [Service] +Type=notify ExecStart=@EXPANDED_BINDIR@/dbus-daemon --system --address=systemd: --nofork --nopidfile --systemd-activation --syslog-only ExecReload=@EXPANDED_BINDIR@/dbus-send --print-reply --system --type=method_call --dest=org.freedesktop.DBus / org.freedesktop.DBus.ReloadConfig OOMScoreAdjust=-900 diff --git a/bus/systemd-user/dbus.service.in b/bus/systemd-user/dbus.service.in index 7ceffbee..6ac32a49 100644 --- a/bus/systemd-user/dbus.service.in +++ b/bus/systemd-user/dbus.service.in @@ -4,5 +4,6 @@ Documentation=man:dbus-daemon(1) Requires=dbus.socket [Service] +Type=notify ExecStart=@EXPANDED_BINDIR@/dbus-daemon --session --address=systemd: --nofork --nopidfile --systemd-activation --syslog-only ExecReload=@EXPANDED_BINDIR@/dbus-send --print-reply --session --type=method_call --dest=org.freedesktop.DBus / org.freedesktop.DBus.ReloadConfig diff --git a/dbus/dbus-sysdeps-util-unix.c b/dbus/dbus-sysdeps-util-unix.c index b841bf63..838cd932 100644 --- a/dbus/dbus-sysdeps-util-unix.c +++ b/dbus/dbus-sysdeps-util-unix.c @@ -1519,3 +1519,15 @@ _dbus_get_session_config_file (DBusString *str) return _dbus_string_append (str, DBUS_SESSION_CONFIG_FILE); } + +/** + * Report to a service manager that the daemon calling this function is + * ready for use. This is currently only implemented for systemd. + */ +void +_dbus_daemon_report_ready (void) +{ +#ifdef HAVE_SYSTEMD + sd_notify (0, "READY=1"); +#endif +} diff --git a/dbus/dbus-sysdeps-util-win.c b/dbus/dbus-sysdeps-util-win.c index 1ef4ae6c..f613130e 100644 --- a/dbus/dbus-sysdeps-util-win.c +++ b/dbus/dbus-sysdeps-util-win.c @@ -1654,3 +1654,8 @@ _dbus_get_session_config_file (DBusString *str) return _dbus_get_config_file_name(str, "session.conf"); } + +void +_dbus_daemon_report_ready (void) +{ +} diff --git a/dbus/dbus-sysdeps.h b/dbus/dbus-sysdeps.h index b9b0c440..b2943906 100644 --- a/dbus/dbus-sysdeps.h +++ b/dbus/dbus-sysdeps.h @@ -687,6 +687,8 @@ dbus_bool_t _dbus_rlimit_restore_fd_limit (DBusRLimit *saved, DBusError *error); void _dbus_rlimit_free (DBusRLimit *lim); +void _dbus_daemon_report_ready (void); + /** @} */ DBUS_END_DECLS -- 2.15.1