From 9fbb7960f9c3621d7e8de769168c4c5eb8a1d092 Mon Sep 17 00:00:00 2001 From: Simon McVittie Date: Tue, 16 Jan 2018 13:15:34 +0000 Subject: [PATCH 04/11] _dbus_credentials_to_string_append: Remove useless join = FALSE It can't actually matter in practice, because we never know the Unix uid and Unix groups but not pid, and we never have a Windows SID and also a Linux security label; but resetting join to FALSE can only ever result in us outputting something like "foo=123bar=456" instead of the intended form with a space in the middle. Signed-off-by: Simon McVittie --- dbus/dbus-credentials.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/dbus/dbus-credentials.c b/dbus/dbus-credentials.c index 5b585f37..dfd4522b 100644 --- a/dbus/dbus-credentials.c +++ b/dbus/dbus-credentials.c @@ -681,8 +681,6 @@ _dbus_credentials_to_string_append (DBusCredentials *credentials, goto oom; join = TRUE; } - else - join = FALSE; if (credentials->unix_gids != NULL) { @@ -705,8 +703,6 @@ _dbus_credentials_to_string_append (DBusCredentials *credentials, goto oom; join = TRUE; } - else - join = FALSE; if (credentials->linux_security_label != NULL) { -- 2.15.1