From 003f0b07f16f7d27f599dff11afb09855b789af8 Mon Sep 17 00:00:00 2001 From: Michael Catanzaro Date: Sat, 30 Jun 2018 18:11:58 -0500 Subject: [PATCH 5/6] Don't forget to free resources in an early return This upstreams the fix from https://gitlab.gnome.org/GNOME/glib/commit/83d34f630939aa13539e03895bef87da738c4127 https://bugs.freedesktop.org/show_bug.cgi?id=100733 --- src/xdgmimemagic.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/xdgmimemagic.c b/src/xdgmimemagic.c index a2320f5..6cfe4b4 100644 --- a/src/xdgmimemagic.c +++ b/src/xdgmimemagic.c @@ -272,7 +272,10 @@ _xdg_mime_magic_parse_header (FILE *magic_file, XdgMimeMagicMatch *match) buffer = (char *)_xdg_mime_magic_read_to_newline (magic_file, &end_of_file); if (end_of_file) - return XDG_MIME_MAGIC_EOF; + { + free (buffer); + return XDG_MIME_MAGIC_EOF; + } end_ptr = buffer; while (*end_ptr != ']' && *end_ptr != '\000' && *end_ptr != '\n') -- 2.17.1