From d2c5acd1c2ca57a90d93411b841d355a2d42825a Mon Sep 17 00:00:00 2001 From: Simon McVittie Date: Wed, 11 Jul 2018 16:16:38 +0100 Subject: [PATCH 4/7] dbus_server_listen: Don't leak first_connect_error If an implementation fails to listen, and a subsequent implementation succeeds, then we would have leaked this. Detected by running tests/loopback.c under valgrind. Signed-off-by: Simon McVittie --- dbus/dbus-server.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dbus/dbus-server.c b/dbus/dbus-server.c index 3243af6c..607eae94 100644 --- a/dbus/dbus-server.c +++ b/dbus/dbus-server.c @@ -685,6 +685,7 @@ dbus_server_listen (const char *address, } else { + dbus_error_free (&first_connect_error); _DBUS_ASSERT_ERROR_IS_CLEAR (error); return server; } -- 2.18.0