From 3999273cdc25220d4614e2b535193dbeeab26d01 Mon Sep 17 00:00:00 2001 From: Debarshi Ray Date: Fri, 6 May 2011 02:05:46 +0300 Subject: [PATCH 2/3] idletest: return an empty RPL_WHOISCHANNELS in response to WHOIS RFC 2812 defines RPL_WHOISCHANNELS as: " :*( ( "@" / "+" ) " " )" Therefore, there is the possibility of an empty message even though preliminary testing with some IRC daemons (eg., Freenode, GIMPNet and IRCNet) did not reveal such a scenario. Nevertheless to maintain strict compliance with the RFC we should test for this as well. Fixes: https://bugs.freedesktop.org/34796 --- tests/twisted/idletest.py | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/tests/twisted/idletest.py b/tests/twisted/idletest.py index 9785413..9136cbc 100644 --- a/tests/twisted/idletest.py +++ b/tests/twisted/idletest.py @@ -80,6 +80,7 @@ class BaseIRCServer(irc.IRC): self.sendMessage('311', self.nick, self.nick, self.user, 'idle.test.client', '*', ':%s' % self.real_name, prefix='idle.test.server') if self.rooms: self.sendMessage('319', self.nick, self.nick, ':%s' % ' '.join(self.rooms), prefix='idle.test.server') + self.sendMessage('319', self.nick, self.nick, ':', prefix='idle.test.server') self.sendMessage('312', self.nick, self.nick, 'idle.test.server', ':Idle Test Server', prefix='idle.test.server') if self.secure: self.sendMessage('671', self.nick, self.nick, ':is using a secure connection', prefix='idle.test.server') -- 1.7.4.4