Attachment 4832 Details for Bug 6152 – Proposed patch

[patch] Proposed patch

poppler-action-named.diff (text/plain), 1.34 KB, created by Carlos Garcia Campos on 2006-03-06 02:49:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Carlos Garcia Campos

Created: 2006-03-06 02:49:21 UTC

Size: 1.34 KB

patch

obsolete

>Index: ChangeLog
>===================================================================
>RCS file: /cvs/poppler/poppler/ChangeLog,v
>retrieving revision 1.321
>diff -u -u -r1.321 ChangeLog
>--- ChangeLog	28 Feb 2006 23:24:59 -0000	1.321
>+++ ChangeLog	5 Mar 2006 15:29:13 -0000
>@@ -1,3 +1,7 @@
>+2006-03-05  Carlos Garcia Campos  <carlosgc@gnome.org>
>+
>+	* glib/poppler-action.cc: Add support for Action Named links
>+
> 2006-02-28  Kristian HÃ¸gsberg  <krh@redhat.com>
> 
> 	* configure.ac: Bump release to 0.5.1.
>Index: glib/poppler-action.cc
>===================================================================
>RCS file: /cvs/poppler/poppler/glib/poppler-action.cc,v
>retrieving revision 1.6
>diff -u -u -r1.6 poppler-action.cc
>--- glib/poppler-action.cc	18 Jan 2006 22:32:13 -0000	1.6
>+++ glib/poppler-action.cc	5 Mar 2006 15:29:13 -0000
>@@ -246,9 +246,13 @@
> 
> static void
> build_named (PopplerAction *action,
>-	     LinkAction    *link)
>+	     LinkNamed     *link)
> {
>-	/* FIXME: Write */
>+	gchar *name;
>+
>+	name = link->getName ()->getCString ();
>+	if (name != NULL)
>+		action->named.named_dest = g_strdup (name);
> }
> 
> static void
>@@ -294,7 +298,7 @@
> 		break;
> 	case actionNamed:
> 		action->type = POPPLER_ACTION_NAMED;
>-		build_named (action, link);
>+		build_named (action, dynamic_cast <LinkNamed *> (link));
> 		break;
> 	case actionMovie:
> 		action->type = POPPLER_ACTION_MOVIE;

Actions: View | Splinter Review

Attachments on bug 6152: 4832

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.