From e601cd16ce0594a8e3386b00b50b8352922f5f10 Mon Sep 17 00:00:00 2001 From: Xavier Claessens Date: Thu, 14 Jul 2011 09:21:36 +0200 Subject: [PATCH] Add a comment explaining why we cannot let make TpContact subclasses yet --- telepathy-glib/contact.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/telepathy-glib/contact.c b/telepathy-glib/contact.c index 8d2bae4..612b08d 100644 --- a/telepathy-glib/contact.c +++ b/telepathy-glib/contact.c @@ -1352,6 +1352,15 @@ _tp_contact_new (TpConnection *connection, return self; } +/* FIXME: Ideally this should be replaced with + * + * tp_simple_client_factory_dup_contact (tp_proxy_get_factory (connection), + * handle, identifier); + * + * but we cannot assert CM has immortal handles (yet). That means we cannot + * guarantee that all TpContact objects are created through the factory and so + * let it make TpContact subclasses. + */ static TpContact * tp_contact_ensure (TpConnection *connection, TpHandle handle) -- 1.7.4.1