From d688b19ccf6a58fe8e0735a24b45ad145ad15758 Mon Sep 17 00:00:00 2001 From: Simon McVittie Date: Thu, 21 Jul 2011 13:06:21 +0100 Subject: [PATCH 1/3] update_desktop_file_entry: don't leak file_path on one particular OOM Revenge of #33126: most, but not all, temporary variables were freed on this code path. https://bugs.freedesktop.org/show_bug.cgi?id=39230 --- bus/activation.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/bus/activation.c b/bus/activation.c index 3177d02..c1f0e94 100644 --- a/bus/activation.c +++ b/bus/activation.c @@ -457,8 +457,7 @@ update_desktop_file_entry (BusActivation *activation, * the entries hash table */ _dbus_hash_table_remove_string (entry->s_dir->entries, entry->filename); - bus_activation_entry_unref (entry); - return FALSE; + goto out; } } -- 1.7.5.4