From b027dec710b2680a18266dd59645ba7f55f3e606 Mon Sep 17 00:00:00 2001 From: Alban Browaeys Date: Wed, 3 Aug 2011 00:00:54 +0200 Subject: [PATCH] libcolord: cd client - remove duplicate call to complete Cd client calls complete of g_simple_async_result twice. This leads to segfault when the caller reads the error (if there was an error to connect) as Cd client finish handler free the error. --- libcolord/cd-client.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/libcolord/cd-client.c b/libcolord/cd-client.c index 9167efa..34df219 100644 --- a/libcolord/cd-client.c +++ b/libcolord/cd-client.c @@ -320,7 +320,6 @@ cd_client_connect_cb (GObject *source_object, if (client->priv->proxy == NULL) { g_simple_async_result_set_from_error (G_SIMPLE_ASYNC_RESULT (res_source), error); - g_simple_async_result_complete (G_SIMPLE_ASYNC_RESULT (res_source)); g_error_free (error); goto out; } -- 1.7.6