From 2d367ca99c58f50c3e06d11f55e1a6da97ebe79f Mon Sep 17 00:00:00 2001 From: Simon McVittie Date: Mon, 26 Sep 2011 12:35:07 +0100 Subject: [PATCH 5/5] sysdeps: remove misleading comments The comment claims that _dbus_full_duplex_pipe() is only used for the debug-pipe server, but in fact the process-spawning code uses it now (on both Unix and Windows platforms). --- dbus/dbus-sysdeps-unix.c | 5 ----- dbus/dbus-sysdeps-win.c | 5 ----- 2 files changed, 0 insertions(+), 10 deletions(-) diff --git a/dbus/dbus-sysdeps-unix.c b/dbus/dbus-sysdeps-unix.c index f51f6fc..dfe7b53 100644 --- a/dbus/dbus-sysdeps-unix.c +++ b/dbus/dbus-sysdeps-unix.c @@ -2937,11 +2937,6 @@ _dbus_print_backtrace (void) * * Marks both file descriptors as close-on-exec * - * @todo libdbus only uses this for the debug-pipe server, so in - * principle it could be in dbus-sysdeps-util.c, except that - * dbus-sysdeps-util.c isn't in libdbus when tests are enabled and the - * debug-pipe server is used. - * * @param fd1 return location for one end * @param fd2 return location for the other end * @param blocking #TRUE if pipe should be blocking diff --git a/dbus/dbus-sysdeps-win.c b/dbus/dbus-sysdeps-win.c index a8c60bd..11df51a 100644 --- a/dbus/dbus-sysdeps-win.c +++ b/dbus/dbus-sysdeps-win.c @@ -799,11 +799,6 @@ failed: * Creates a full-duplex pipe (as in socketpair()). * Sets both ends of the pipe nonblocking. * - * @todo libdbus only uses this for the debug-pipe server, so in - * principle it could be in dbus-sysdeps-util.c, except that - * dbus-sysdeps-util.c isn't in libdbus when tests are enabled and the - * debug-pipe server is used. - * * @param fd1 return location for one end * @param fd2 return location for the other end * @param blocking #TRUE if pipe should be blocking -- 1.7.6.3