Silence 78 gcc-3.4.6 warnings missing binary operator before token "xxx" due to mistreated gccmakedep arguments. E.g., in xc/programs/Xserver/hw/xfree/xf86config: gccmakedep ... -DXORG_VERSION_CURRENT="(((6) * 10000000) + ((9) * 100000) + ((0) * 1000) + 0)" I prefer gccmakedep instead of makedepend, because (1) makedepend mishandles "computed include directives", e.g., ft2build.h & Co., and (2) gccmakedep does "The Real Thing (TM)". diff -ur -N XOrg-6.9.0.orig/xc/config/util/gccmdep.cpp XOrg-6.9.0/xc/config/util/gccmdep.cpp --- XOrg-6.9.0.orig/xc/config/util/gccmdep.cpp 2004-04-23 20:42:00.000000000 +0200 +++ XOrg-6.9.0/xc/config/util/gccmdep.cpp 2006-06-13 22:30:35.000000000 +0200 @@ -32,7 +32,9 @@ else case "$1" in -D*|-I*|-U*) - args="$args '$1'" +XCOMM arg may contain single quotes + qarg=`echo "$1" | sed "s/'/'\\\\\\\\''/g"` + args="$args '$qarg'" ;; -g*|-O*) ;; @@ -74,7 +76,8 @@ echo "Unknown option '$1' ignored" 1>&2 ;; *) - files="$files $1" +XCOMM filename may contain blanks + files="$files '$1'" ;; esac fi @@ -115,7 +118,8 @@ if [ X"$makefile" != X- ]; then CMD="$CMD >> $TMP" fi -eval $CMD +XCOMM Do not wilcard expand '*' in args +eval "$CMD" if [ X"$makefile" != X- ]; then $RM ${makefile}.bak $MV $makefile ${makefile}.bak