From 593df66b84304c0ab0c7c5872af0038f3c68181d Mon Sep 17 00:00:00 2001 From: Dan Nicholson Date: Thu, 7 Jun 2012 05:47:45 -0700 Subject: [PATCH] Make check-missing test more explicit with --exists Currently the check-missing passes the packages on the command line with no options prior to running through --cflags/--libs, etc. Make this more explicitly pass --exists since this is a much more common operation performed from PKG_CHECK_MODULES. The expected result of 0 when Requires or Requires.private is missing is a regression from pre-0.24 pkg-config. --- check/check-missing | 10 ++++++++-- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/check/check-missing b/check/check-missing index fba43a7..1809c4d 100755 --- a/check/check-missing +++ b/check/check-missing @@ -10,13 +10,19 @@ fi # non-existent package; call should fail and cause no output EXPECT_RETURN=1 RESULT="" -ARGS="pkg-non-existent" +ARGS="--exists pkg-non-existent" +run_test + +# existing package, but with missing Requires +EXPECT_RETURN=0 +RESULT="" +ARGS="--exists missing-requires" run_test # tests below are on an existing package, but with missing Requires.private; # when pkg-config outputs error, the actual error text isn't checked # package exists -ARGS="missing-requires-private" +ARGS="--exists missing-requires-private" EXPECT_RETURN=0 RESULT="" run_test -- 1.7.7.6