From f43a9b4a74cf85fcee48fcfa4a049cfb3da9053f Mon Sep 17 00:00:00 2001 From: Hib Eris Date: Mon, 26 Nov 2012 19:03:24 +0100 Subject: [PATCH 1/2] Fix uninitialized warning in TiffWriter Fix warning: CXX TiffWriter.lo ../../poppler/goo/TiffWriter.cc: In member function 'virtual bool TiffWriter::init(FILE*, int, int, int, int)': ../../poppler/goo/TiffWriter.cc:149:59: warning: 'samplesperpixel' may be used uninitialized in this function [-Wuninitialized] ../../poppler/goo/TiffWriter.cc:152:51: warning: 'photometric' may be used uninitialized in this function [-Wuninitialized] --- goo/TiffWriter.cc | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/goo/TiffWriter.cc b/goo/TiffWriter.cc index 660764c..2f3fff5 100644 --- a/goo/TiffWriter.cc +++ b/goo/TiffWriter.cc @@ -6,6 +6,7 @@ // // Copyright (C) 2010, 2012 William Bader // Copyright (C) 2012 Albert Astals Cid +// Copyright (C) 2012 Hib Eris // //======================================================================== @@ -126,6 +127,9 @@ bool TiffWriter::init(FILE *openedFile, int width, int height, int hDPI, int vDP samplesperpixel = 4; photometric = PHOTOMETRIC_SEPARATED; break; + default: + fprintf(stderr, "TiffWriter: Invalid format.\n"); + return false; } // Open the file -- 1.7.5.4