From 17603ea8e8e002c109e99fafcf9746498286c100 Mon Sep 17 00:00:00 2001 From: Kalev Lember Date: Sat, 7 Sep 2013 15:55:24 +0200 Subject: [PATCH 2/6] Enable compiler warnings by default Drop the --enable-strict-cc configure option and replace it with --enable-compile-warnings from gnome-common. This is enabled by default to make sure warnings show up during development. https://bugs.freedesktop.org/show_bug.cgi?id=69102 --- configure.ac | 6 +----- demo/Makefile.am | 1 + src/Makefile.am | 1 + 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index a2c04e7..d78f420 100644 --- a/configure.ac +++ b/configure.ac @@ -96,11 +96,7 @@ else fi AM_CONDITIONAL([BUILD_GEOIP_SERVER], [test "x$build_geoip_server" = "xyes"]) -dnl Strict compiler -AC_ARG_ENABLE([strict-cc], - AS_HELP_STRING([--enable-strict-cc],[Enable strict C compiler])) - -AS_IF([test "x$enable_strict_cc" = "xyes"], [CFLAGS="$CFLAGS -Wall -Werror"]) +GNOME_COMPILE_WARNINGS([maximum]) dnl Debugging AC_ARG_ENABLE(debug, diff --git a/demo/Makefile.am b/demo/Makefile.am index b0b15bc..b3d15fa 100644 --- a/demo/Makefile.am +++ b/demo/Makefile.am @@ -2,5 +2,6 @@ noinst_PROGRAMS = where-am-i where_am_i_SOURCES = where-am-i.c where_am_i_CFLAGS = $(GEOCLUE_CFLAGS) \ + $(WARN_CFLAGS) \ -DLOCALEDIR="\"$(datadir)/locale\"" where_am_i_LDADD = $(GEOCLUE_LIBS) diff --git a/src/Makefile.am b/src/Makefile.am index ad4bab5..b0bc7b2 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -44,6 +44,7 @@ geoclue_SOURCES = \ $(NULL) geoclue_CFLAGS = $(GEOCLUE_CFLAGS) \ + $(WARN_CFLAGS) \ -DLOCALEDIR="\"$(datadir)/locale\"" geoclue_LDADD = $(GEOCLUE_LIBS) $(LIBS) -- 1.8.3.1