From 08d793d341e426b2466cf3e57b9846a45b281ef9 Mon Sep 17 00:00:00 2001 From: Guillaume Desmottes Date: Thu, 30 Jan 2014 11:52:20 +0100 Subject: [PATCH] remove CM side password storage API They have been DRAFT for years and doesn't really make sense. https://bugs.freedesktop.org/show_bug.cgi?id=33485 --- ...ccount_Interface_External_Password_Storage1.xml | 59 ---------- spec/Channel_Interface_Credentials_Storage1.xml | 60 ---------- ...nnection_Manager_Interface_Account_Storage1.xml | 121 --------------------- spec/all.xml | 3 - 4 files changed, 243 deletions(-) delete mode 100644 spec/Account_Interface_External_Password_Storage1.xml delete mode 100644 spec/Channel_Interface_Credentials_Storage1.xml delete mode 100644 spec/Connection_Manager_Interface_Account_Storage1.xml diff --git a/spec/Account_Interface_External_Password_Storage1.xml b/spec/Account_Interface_External_Password_Storage1.xml deleted file mode 100644 index bfc7fd9..0000000 --- a/spec/Account_Interface_External_Password_Storage1.xml +++ /dev/null @@ -1,59 +0,0 @@ - - - - Copyright © 2011 Collabora Ltd. - -

This library is free software; you can redistribute it and/or - modify it under the terms of the GNU Lesser General Public - License as published by the Free Software Foundation; either - version 2.1 of the License, or (at your option) any later version.

- -

This library is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - Lesser General Public License for more details.

- -

You should have received a copy of the GNU Lesser General Public - License along with this library; if not, write to the Free Software - Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA - 02110-1301, USA.

- - - - - (draft 1) - - - -

An interface for Accounts whose passwords are stored externally and - SHOULD NOT be stored by either the - AccountManager nor any - ServerAuthentication1 - handler.

- -

This interface SHOULD only appear on accounts for which the - related Connection Manager implements - ConnectionManager.Interface.AccountStorage1.

- - - - - Clears any saved password associated with this account. - - - - - -

Indicates whether the account has a saved password or not.

- -

Change notification for this property is provided by the - standard D-Bus PropertiesChanged signal.

- - - - - diff --git a/spec/Channel_Interface_Credentials_Storage1.xml b/spec/Channel_Interface_Credentials_Storage1.xml deleted file mode 100644 index 00ecd5b..0000000 --- a/spec/Channel_Interface_Credentials_Storage1.xml +++ /dev/null @@ -1,60 +0,0 @@ - - - Copyright © 2011 Collabora Limited - -

This library is free software; you can redistribute it and/or -modify it under the terms of the GNU Lesser General Public -License as published by the Free Software Foundation; either -version 2.1 of the License, or (at your option) any later version.

- -

This library is distributed in the hope that it will be useful, -but WITHOUT ANY WARRANTY; without even the implied warranty of -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU -Lesser General Public License for more details.

- -

You should have received a copy of the GNU Lesser General Public -License along with this library; if not, write to the Free Software -Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.

- - - - (draft 1) - - -

A channel interface for SASL authentication channels that can save the - credentials in the connection manager.

- -

This interface is unlikely to be present for any SASL channels that are - more complex than a simple password prompt (e.g. - X-TELEPATHY-PASSWORD or PLAIN).

- -

In practice, this interface should only be implemented by connection - managers that implement the ConnectionManager.Interface.AccountStorage1 - interface. To clear a password that has been saved in this manner, a - client should call AccountStorage1.ForgetCredentials - on the Account.

- - - - - - Whether to store the authentication credentials. - - - -

This method tells the connection manager whether to store the - authentication response in order to allow the connection manager to - sign-on automatically in the future.

-

If credentials have been stored in this way, the client SHOULD NOT - attempt to store the credentials locally in a keyring.

-

This method MUST be called before AcceptSASL - is called or it will have no effect.

- - - - diff --git a/spec/Connection_Manager_Interface_Account_Storage1.xml b/spec/Connection_Manager_Interface_Account_Storage1.xml deleted file mode 100644 index c50a255..0000000 --- a/spec/Connection_Manager_Interface_Account_Storage1.xml +++ /dev/null @@ -1,121 +0,0 @@ - - - - Copyright © 2011 Collabora Ltd. - -

This library is free software; you can redistribute it and/or - modify it under the terms of the GNU Lesser General Public - License as published by the Free Software Foundation; either - version 2.1 of the License, or (at your option) any later version.

- -

This library is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - Lesser General Public License for more details.

- -

You should have received a copy of the GNU Lesser General Public - License along with this library; if not, write to the Free Software - Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA - 02110-1301, USA.

- - - - - (draft 1) - - - -

An interface for connection managers that store account details - internally. At the moment this consists only of storing an account's - credentials, but other functionality may be added in the future.

- -

Account objects - representing accounts on a connection manager that implements this - interface should implement the - ExternalPasswordStorage1 - interface.

- - - - - A set of flags representing the status of the Account stored in the - Connection Manager. - - - - - The associated account has its authentication credentials (password) - stored in the connection manager - - - - - - A mapping from Account_Ids to account flags. - - - - - - - -

The set of Accounts stored in this Connection Manager, and flags - indicating their status.

- -

Change notification for this property is provided by the standard - D-Bus PropertiesChanged signal.

- - - - - - Clears any saved credentials associated with the specified Account_Id. - Any other saved data related to the account will be unaffected. - - - - - An account id as returned from - Protocol.IdentifyAccount. - - - - - - - The account id is invalid. - - - - - - - - Completely removes all data associated with an account from the - connection manager's internal storage. - - - - - An account id as returned from - Protocol.IdentifyAccount. - - - - - - - The account id is invalid. - - - - - - - diff --git a/spec/all.xml b/spec/all.xml index 26fd31d..d9257b8 100644 --- a/spec/all.xml +++ b/spec/all.xml @@ -32,7 +32,6 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. - @@ -161,7 +160,6 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. - @@ -263,7 +261,6 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. - -- 1.8.5.3