From 41a3fa2612093fdb1051a6836cada7b613cc2068 Mon Sep 17 00:00:00 2001 From: Simon McVittie Date: Thu, 20 Mar 2014 12:53:39 +0000 Subject: [PATCH 3/3] dispatcher_delegate_channels: initialize am Otherwise, if we "goto error" too soon, we'll try to g_object_unref uninitialized memory. gcc doesn't spot that because we're using tp_clear_object, which uses an intermediate variable, and it doesn't propagate "uninitializedness" through assignments. --- src/mcd-dispatcher.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mcd-dispatcher.c b/src/mcd-dispatcher.c index 2fc0828..b004b09 100644 --- a/src/mcd-dispatcher.c +++ b/src/mcd-dispatcher.c @@ -2126,7 +2126,7 @@ dispatcher_delegate_channels ( gchar *sender = NULL; McdConnection *conn = NULL; DelegateChannelsCtx *ctx = NULL; - McdAccountManager *am; + McdAccountManager *am = NULL; guint i; GList *l; -- 1.9.1