Bug 101267

Summary: [PATCH] Fix PackageKit stack smashing on i586 machine when "pkcon get-updates"
Product: PackageKit Reporter: Jonathan Kang <jonathankang>
Component: backend-zyppAssignee: Scott Reeves <scottreeves4>
Status: RESOLVED NOTABUG QA Contact:
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: zypp: Fix stack smashing on 32-bit system

Description Jonathan Kang 2017-06-01 06:20:30 UTC
The patch in this bug fixes the problem reported in https://bugzilla.opensuse.org/show_bug.cgi?id=1020028.
Comment 1 Jonathan Kang 2017-06-01 06:25:12 UTC
Created attachment 131632 [details] [review]
zypp: Fix stack smashing on 32-bit system

PackageKit(using zypp backend) will crash when running
"pkcon get-updates" on 32-bit system.

Fix that by adding -D_FILE_OFFSET_BITS=64 to
libpk_backend_zypp_la_CPPFLAGS.
Comment 2 Richard Hughes 2017-06-01 07:57:21 UTC
Is this the right fix? Surely that define should be set in configure.ac for all plugins?
Comment 3 Jonathan Kang 2017-06-01 08:00:20 UTC
(In reply to Richard Hughes from comment #2)
> Is this the right fix? Surely that define should be set in configure.ac for
> all plugins?

It's only for zypp backend. This is an issue of libzypp, adding
-D_FILE_OFFSET_BITS=64 avoids it.
Comment 4 Richard Hughes 2018-08-21 15:52:55 UTC
We moved the upstream bugtracker to GitHub a long time ago. If this issue still affects you please re-create the issue here: https://github.com/hughsie/PackageKit/issues
 
Sorry for the impersonal message, and fingers crossed your issue no longer happens. Thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.