Bug 107121

Summary:	[CI] drv_selftest@mock_requests triggers lockdep correctness validator
Product:	DRI	Reporter:	Tomi Sarvela <tomi.p.sarvela>
Component:	DRM/Intel	Assignee:	Intel GFX Bugs mailing list <intel-gfx-bugs>
Status:	CLOSED FIXED	QA Contact:	Intel GFX Bugs mailing list <intel-gfx-bugs>
Severity:	normal
Priority:	medium	CC:	intel-gfx-bugs
Version:	DRI git
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Tomi Sarvela 2018-07-05 09:45:42 UTC

DRM-Tip build CI_DRM_4427 was ok:
aae8cb6bbd49dbadce13baff5077a7b025efd362
2018y-07m-04d-20h-04m-08s UTC integration manifest

DRM-Tip build CI_DRM_4428 was not ok:
7bc1be8128e30b4d581b913feff5c78909c00945
2018y-07m-04d-20h-25m-35s UTC integration manifest

Example trace:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_4428/shard-snb2/igt@drv_selftest@mock_requests.html

[   62.756674] Setting dangerous option mock_selftests - tainting kernel
[   63.800293] INFO: trying to register non-static key.
[   63.800300] the code is fine but needs lockdep annotation.
[   63.800303] turning off the locking correctness validator.
[   63.800308] CPU: 6 PID: 160 Comm: kworker/u16:5 Tainted: G     U            4.18.0-rc3-CI-CI_DRM_4428+ #1
[   63.800313] Hardware name: Dell Inc. XPS 8300  /0Y2MRG, BIOS A06 10/17/2011
[   63.800374] Workqueue: mock contexts_free_worker [i915]
[   63.800378] Call Trace:
[   63.800384]  dump_stack+0x67/0x9b
[   63.800389]  register_lock_class+0x595/0x5a0
[   63.800394]  ? ret_from_fork+0x3a/0x50
[   63.800399]  __lock_acquire+0xcb/0x1b50
[   63.800441]  ? i915_address_space_fini+0x14/0xd0 [i915]
[   63.800447]  ? lock_acquire+0xa6/0x210
[   63.800450]  lock_acquire+0xa6/0x210
[   63.800490]  ? i915_address_space_fini+0x14/0xd0 [i915]
[   63.800495]  _raw_spin_lock+0x2a/0x40
[   63.800532]  ? i915_address_space_fini+0x14/0xd0 [i915]
[   63.800569]  i915_address_space_fini+0x14/0xd0 [i915]
[   63.800606]  i915_ppgtt_release+0x12d/0x340 [i915]
[   63.800644]  i915_gem_context_free+0xdd/0x170 [i915]
[   63.800680]  contexts_free_worker+0x45/0x90 [i915]
[   63.800687]  process_one_work+0x248/0x6c0
[   63.800692]  worker_thread+0x37/0x380
[   63.800696]  ? process_one_work+0x6c0/0x6c0
[   63.800700]  kthread+0x119/0x130
[   63.800704]  ? kthread_flush_work_fn+0x10/0x10
[   63.800708]  ret_from_fork+0x3a/0x50

Comment 1 Chris Wilson 2018-07-05 09:50:52 UTC

See https://patchwork.freedesktop.org/series/45958/

Comment 2 Chris Wilson 2018-07-05 11:09:45 UTC

commit 0f17d5dd2199555830482b638a5fc8bf915f2f10 (HEAD -> drm-intel-next-queued, drm-intel/for-linux-next, drm-intel/drm-intel-next-queued)
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Thu Jul 5 07:56:53 2018 +0100

    drm/i915/selftests: Replace open-coded i915_address_space_init()
    
    Use i915_address_space_init() rather than open-code it inside
    mock_ppgtt() as we will forget to keep it in sync.
    
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
    Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20180705065653.20449-3-chris@chris-wilson.co.uk

Comment 3 Martin Peres 2018-07-10 11:35:10 UTC

Thanks, it did the trick :)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.