| Summary: | [REGRESSION] [BISECTED] Segmentation fault in si_bind_blend_state after removal of the blend state NULL check | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | Edmondo Tommasina <edmondo.tommasina> |
| Component: | Drivers/Gallium/radeonsi | Assignee: | Default DRI bug account <dri-devel> |
| Status: | RESOLVED FIXED | QA Contact: | Default DRI bug account <dri-devel> |
| Severity: | normal | ||
| Priority: | medium | CC: | 0xe2.0x9a.0x9b |
| Version: | git | ||
| Hardware: | x86-64 (AMD64) | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
Backtrace
possible fix |
||
|
Description
Edmondo Tommasina
2019-08-17 20:59:33 UTC
Created attachment 145103 [details] [review] possible fix Does the attached patch fix it? Thanks. Yes, the attached patch fix the it. (In reply to Marek Olšák from comment #1) > Created attachment 145103 [details] [review] [review] > possible fix > > Does the attached patch fix it? Yes, it fixed vdpau with Mplayer for me. mplayer -vo vdpau /data/Filme/test.mkv > & /dev/null Soo... Tested-by: Dieter Nützel <Dieter@nuetzel-hh.de> But mpv -hwdec vdpau /data/Filme/test.mkv > & /dev/null Abbruch (core dumped) Have to bisect. @Dieter: I cannot reproduce your issue with mpv and Marek's patch applied. It looks good.
$ mpv -hwdec mytest.mkv
Playing: mytest.mkv
(+) Video --vid=1 (*) (h264 1280x720 23.976fps)
(+) Audio --aid=1 --alang=eng (*) (aac 2ch 44100Hz)
Subs --sid=1 --slang=eng (subrip)
File tags:
Title: mytest
Using hardware decoding (vdpau).
AO: [pulse] 44100Hz stereo 2ch float
VO: [gpu] 1280x720 vdpau[yuv420p]
AV: 00:00:32 / 00:42:26 (1%) A-V: 0.000
Hello Edmondo, thank you for your comment. Now, I get this: mpv -hwdec /data/Filme/test.mkv Playing: /data/Filme/test.mkv (+) Video --vid=1 (*) 'OceanWorld.2D.2009.BluRay.1080p.AC3.x264-CHD' (h264 1920x1080 24.000fps) (+) Audio --aid=1 --alang=eng (*) 'AC3 5.1 channels, 640kbps' (ac3 6ch 48000Hz) File tags: Title: 深海探奇 2D ATTENTION: default value of option mesa_glthread overridden by environment. ATTENTION: option value of option mesa_glthread ignored. ATTENTION: default value of option mesa_glthread overridden by environment. ATTENTION: option value of option mesa_glthread ignored. mesa: for the --simplifycfg-sink-common option: may only occur zero or one times! mesa: for the --global-isel-abort option: may only occur zero or one times! mpv: ../src/gallium/state_trackers/vdpau/vdpau_private.h:138: FormatYCBCRToPipe: Assertion `0' failed. Abbruch (core dumped) (gdb) bt full
#0 0x00007f2ec9e5ddd1 in raise () from /lib64/libc.so.6
No symbol table info available.
#1 0x00007f2ec9e47549 in abort () from /lib64/libc.so.6
No symbol table info available.
#2 0x00007f2ec9e47421 in __assert_fail_base.cold () from /lib64/libc.so.6
No symbol table info available.
#3 0x00007f2ec9e56322 in __assert_fail () from /lib64/libc.so.6
No symbol table info available.
#4 0x00007f2e66d99c16 in FormatYCBCRToPipe (vdpau_format=7)
at ../src/gallium/state_trackers/vdpau/vdpau_private.h:138
__PRETTY_FUNCTION__ = "FormatYCBCRToPipe"
#5 0x00007f2e66d9a00e in vlVdpVideoSurfaceQueryGetPutBitsYCbCrCapabilities (device=1,
surface_chroma_type=2, bits_ycbcr_format=7, is_supported=0x7f2eba775630)
at ../src/gallium/state_trackers/vdpau/query.c:157
dev = 0x7f2ea802fbf0
pscreen = 0x7f2ea8571b20
#6 0x00007f2ec7e4aa95 in ?? () from /usr/lib64/libavutil.so.56
No symbol table info available.
#7 0x00007f2ec7e4593e in av_hwdevice_ctx_init () from /usr/lib64/libavutil.so.56
No symbol table info available.
#8 0x000055e6b254ca9d in mp_vdpau_create_device_x11 ()
@Marek This one could be CLOSED. Your commit SOLVED it. My reported 'mpv' bug is compilation related. mpv: ../src/gallium/state_trackers/vdpau/vdpau_private.h:138: FormatYCBCRToPipe: Assertion `0' failed. openSUSE Tumbleweed's Mesa 19.1.5 fine (release ?!). Mesa git with LLVM 10.0.0, gcc 9.1.1 meson ../ --strip --buildtype release ... is fine, too. But meson ../ --strip --buildtype debugoptimized ... is brocken, now. Worked for ages, before. Thanks Dieter for clarifying. Patch got merged in mesa: https://gitlab.freedesktop.org/mesa/mesa/commit/f95a28d3 I'm closing this issue. Thanks for the fix. (In reply to Dieter Nützel from comment #7) > mpv: ../src/gallium/state_trackers/vdpau/vdpau_private.h:138: > FormatYCBCRToPipe: Assertion `0' failed. > > [...] > > meson ../ --strip --buildtype release ... is fine, too. Assertions are disabled by default for release builds. The assertion failure is still a bug, though a separate one from that reported here. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.