Bug 111605

Summary: [CI][SHARDS] igt@kms_atomic@plane_primary_overlay_zpos - skip - Test requirement: igt_plane_has_format_mod(overlay, format_overlay, 0x0), SKIP
Product: DRI Reporter: Martin Peres <martin.peres>
Component: DRM/IntelAssignee: Intel GFX Bugs mailing list <intel-gfx-bugs>
Status: RESOLVED MOVED QA Contact: Intel GFX Bugs mailing list <intel-gfx-bugs>
Severity: not set    
Priority: high CC: intel-gfx-bugs, swati2.sharma
Version: XOrg git   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: CML, ICL, TGL i915 features: display/Other

Description Martin Peres 2019-09-09 10:16:44 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6846/shard-iclb2/igt@kms_atomic@plane_primary_overlay_zpos.html

Starting subtest: plane_primary_overlay_zpos
Test requirement not met in function __real_main941, file ../tests/kms_atomic.c:1002:
Test requirement: igt_plane_has_format_mod(overlay, format_overlay, 0x0)
Subtest plane_primary_overlay_zpos: SKIP (0.000s)
Comment 1 CI Bug Log 2019-09-09 10:17:55 UTC
The CI Bug Log issue associated to this bug has been updated.

### New filters associated

* CML ICL TGL: igt@kms_atomic@plane_primary_overlay_zpos - skip - Test requirement: igt_plane_has_format_mod(overlay, format_overlay, 0x0) Subtest plane_primary_overlay_zpos: SKIP
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6852/shard-iclb5/igt@kms_atomic@plane_primary_overlay_zpos.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3429/shard-iclb1/igt@kms_atomic@plane_primary_overlay_zpos.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6843/shard-iclb2/igt@kms_atomic@plane_primary_overlay_zpos.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3425/shard-iclb4/igt@kms_atomic@plane_primary_overlay_zpos.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6844/shard-iclb7/igt@kms_atomic@plane_primary_overlay_zpos.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14304/shard-iclb5/igt@kms_atomic@plane_primary_overlay_zpos.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14305/shard-iclb2/igt@kms_atomic@plane_primary_overlay_zpos.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6846/shard-iclb2/igt@kms_atomic@plane_primary_overlay_zpos.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6847/shard-iclb8/igt@kms_atomic@plane_primary_overlay_zpos.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14306/shard-iclb2/igt@kms_atomic@plane_primary_overlay_zpos.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5173/shard-iclb7/igt@kms_atomic@plane_primary_overlay_zpos.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6845/shard-iclb4/igt@kms_atomic@plane_primary_overlay_zpos.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6848/shard-iclb2/igt@kms_atomic@plane_primary_overlay_zpos.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_4945/shard-iclb7/igt@kms_atomic@plane_primary_overlay_zpos.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_4946/shard-iclb7/igt@kms_atomic@plane_primary_overlay_zpos.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14307/shard-iclb1/igt@kms_atomic@plane_primary_overlay_zpos.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_4950/shard-iclb8/igt@kms_atomic@plane_primary_overlay_zpos.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14309/shard-iclb8/igt@kms_atomic@plane_primary_overlay_zpos.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14310/shard-iclb4/igt@kms_atomic@plane_primary_overlay_zpos.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6849/shard-iclb3/igt@kms_atomic@plane_primary_overlay_zpos.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14313/shard-iclb7/igt@kms_atomic@plane_primary_overlay_zpos.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3426/shard-iclb5/igt@kms_atomic@plane_primary_overlay_zpos.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_4953/shard-iclb1/igt@kms_atomic@plane_primary_overlay_zpos.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14315/shard-iclb8/igt@kms_atomic@plane_primary_overlay_zpos.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3427/shard-iclb8/igt@kms_atomic@plane_primary_overlay_zpos.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6850/shard-iclb5/igt@kms_atomic@plane_primary_overlay_zpos.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14316/shard-iclb1/igt@kms_atomic@plane_primary_overlay_zpos.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_363/fi-cml-u2/igt@kms_atomic@plane_primary_overlay_zpos.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_363/fi-icl-dsi/igt@kms_atomic@plane_primary_overlay_zpos.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_363/fi-icl-u2/igt@kms_atomic@plane_primary_overlay_zpos.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_363/fi-icl-u3/igt@kms_atomic@plane_primary_overlay_zpos.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_363/fi-icl-u4/igt@kms_atomic@plane_primary_overlay_zpos.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_363/fi-tgl-u/igt@kms_atomic@plane_primary_overlay_zpos.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14318/shard-iclb3/igt@kms_atomic@plane_primary_overlay_zpos.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14319/shard-iclb1/igt@kms_atomic@plane_primary_overlay_zpos.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3428/shard-iclb6/igt@kms_atomic@plane_primary_overlay_zpos.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_364/fi-cml-u2/igt@kms_atomic@plane_primary_overlay_zpos.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_364/fi-icl-dsi/igt@kms_atomic@plane_primary_overlay_zpos.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_364/fi-icl-guc/igt@kms_atomic@plane_primary_overlay_zpos.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_364/fi-icl-u2/igt@kms_atomic@plane_primary_overlay_zpos.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_364/fi-icl-u3/igt@kms_atomic@plane_primary_overlay_zpos.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_364/fi-icl-u4/igt@kms_atomic@plane_primary_overlay_zpos.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_364/fi-tgl-u/igt@kms_atomic@plane_primary_overlay_zpos.html
Comment 2 Swati Sharma 2019-09-11 12:52:38 UTC
Earlier we used to get https://bugs.freedesktop.org/show_bug.cgi?id=110034; IGT skip because zpos property not implemented in i915 driver. 

Recently only immutable zpos property got added into i915 driver
https://patchwork.freedesktop.org/patch/298497/?series=58761&rev=3; IGT skip because plane format is not supported by i915->valid

However, as discussed with Maarten this test won't work anyway since test assumes mutable zpos and i915 enabled immutable zpos. 

Test here should check whether zpos is immutable or mutable and on that basis should give valid reason of skip.
Comment 3 Swati Sharma 2019-09-16 13:37:57 UTC
*User Impact:* This will not cause any functional failure and there won't be much of user impact due to this since i915 implements immutable zpos property where we inform userspace about the *hard-coded* stacking of overlay planes.

The existing test anyhow doesn't test immutable zpos property and only validates mutable zpos property. Either we need to redesign existing test case to validate immutable zpos property(which isn't good option since its not CRC based) or create a new subtest validating immutable zpos property using CRC.

This can be put as low/medium priority.
Comment 4 Martin Peres 2019-11-29 19:26:44 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/drm/intel/issues/404.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.