Bug 1252

Summary: misplaced ; at end of |if| statements hw/xfree86/input/citron/citron.c
Product: xorg Reporter: Dave Jones <davej>
Component: Input/CitronAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: high CC: roland.mainz
Version: git   
Hardware: x86 (IA32)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
patch for problem. none

Description Dave Jones 2004-08-31 09:19:51 UTC
A quick grep reveals these gems..

./programs/Xserver/hw/xfree86/input/citron/citron.c-2141-               res =
cit_GetPacket(priv);
./programs/Xserver/hw/xfree86/input/citron/citron.c:2142:               if ((res
== Success) || (priv->lex_mode == cit_idle));
./programs/Xserver/hw/xfree86/input/citron/citron.c-2143-                      
break;
--
./programs/Xserver/hw/xfree86/input/citron/citron.c-2269-               res =
cit_GetPacket(priv);
./programs/Xserver/hw/xfree86/input/citron/citron.c:2270:               if ((res
== Success) || (priv->lex_mode == cit_idle));
./programs/Xserver/hw/xfree86/input/citron/citron.c-2271-                      
break;
--
./programs/Xserver/hw/xfree86/input/citron/citron.c-2350-               res =
cit_GetPacket(priv);
./programs/Xserver/hw/xfree86/input/citron/citron.c:2351:               if ((res
== Success) || (priv->lex_mode == cit_idle));
./programs/Xserver/hw/xfree86/input/citron/citron.c-2352-                      
break;
--
./programs/Xserver/hw/xfree86/input/citron/citron.c-2740-               res =
cit_GetPacket(priv);
./programs/Xserver/hw/xfree86/input/citron/citron.c:2741:               if ((res
== Success) || (priv->lex_mode == cit_idle));
./programs/Xserver/hw/xfree86/input/citron/citron.c-2742-                      
break;

Due to the ; we'll hit the break; every time.
Comment 1 Dave Jones 2004-08-31 09:22:52 UTC
Created attachment 790 [details] [review]
patch for problem.
Comment 2 Adam Jackson 2004-09-21 21:39:59 UTC
applied, thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.