Bug 16530

Summary: Full screen is broken when using multiple monitors
Product: swfdec Reporter: Patryk Zawadzki <patrys>
Component: pluginAssignee: swfdec ml <swfdec>
Status: RESOLVED FIXED QA Contact: swfdec ml <swfdec>
Severity: normal    
Priority: medium CC: eric225125, thuejk
Version: 0.7.x   
Hardware: x86 (IA32)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:

Description Patryk Zawadzki 2008-06-26 07:07:43 UTC
I'm using two 19" monitors to display a 2560x1024 desktop across two screens. While GTK clips the full screen player to one full monitor, the player itself assumes it has all the 2560x1024 space. Therefore only the left half of each movie is visible. It would be nice if the code checked for the actual size of the window instead of assuming it's equal to the desktop size.
Comment 1 Benjamin Otte 2008-07-25 23:55:08 UTC
*** Bug 16858 has been marked as a duplicate of this bug. ***
Comment 2 Thue Janus Kristensen 2008-08-18 16:43:03 UTC
I looked a bit at the code. I haven't tried actually coding the solution, but it seems like the way to go is to use

gdk_screen_get_monitor_at_window () http://www.gtk.org/api/2.6/gdk/GdkScreen.html#gdk-screen-get-monitor-at-window

to get the monitor number the flash window is at, and then use

gdk_screen_get_monitor_geometry () http://www.gtk.org/api/2.6/gdk/GdkScreen.html#gdk-screen-get-monitor-geometry

to get the actual size of the monitor.

Is the screen size only used for determining full-screen size currently? I got the impression that currently the screen size is found at startup and then cached indefinitely (isn't that risky if X adds support for online resolution changing?).

Since a window can be moved between monitors, it is more elegant to fetch the current monitor and it's size when it is needed, using a callback function.
Comment 3 Benjamin Otte 2008-09-04 15:07:16 UTC
This should be fixed in git.
I managed to convince xrandr to make my laptop have multiple monitors and it works there now. But I'd like other people with weird multi-monitor setups to test this, too.
Comment 4 Riccardo Magliocchetti 2008-09-05 00:59:13 UTC
This still does not work fine here, when you came back from the fullscreen mode and your video is paused it won't resize back to the small size.
Comment 5 Benjamin Otte 2008-09-05 01:22:07 UTC
I assume you're talking about the Mozilla plugin here? If so: yeah, I didn't fix it yet. And what do you mean by "paused"?
Comment 6 Riccardo Magliocchetti 2008-09-05 01:30:52 UTC
Yes, i mean the mozilla plugin. "paused" means that the youtube player is on pause, but i've just verified that it doesn't matter.
Comment 7 Benjamin Otte 2008-09-05 10:20:46 UTC
Just checked in the swfdec-mozilla fix. Please test and close if it works for you.

I'm not sure what you're problem is at all btw, because it worked pretty much fine for me without that checkin, but I hope this thing fixes it.
Comment 8 Riccardo Magliocchetti 2008-09-05 12:34:15 UTC
Latest git works fine, thank you.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.