|Summary:||Better fix for gcc warning|
|Product:||xorg||Reporter:||Matt Turner <mattst88>|
|Component:||Driver/intel||Assignee:||Wang Zhenyu <zhenyu.z.wang>|
|Status:||RESOLVED NOTABUG||QA Contact:||Xorg Project Team <xorg-team>|
|i915 platform:||i915 features:|
Description Matt Turner 2008-07-24 06:34:36 UTC
Created attachment 17856 [details] [review] Better fix For commit 6ac352f146bafe3b4bb5832340eb0ccb730565d2, a better fix exists. Included patch is cleaner and removes an unnecessary variable.
Comment 1 Wang Zhenyu 2008-07-27 23:32:39 UTC
I hope to keep assert as it's.
Comment 2 Wang Zhenyu 2008-07-28 22:14:53 UTC
Matt, we have a intel-gfx mail list on fd.o, which is an ideal place for us to review patches and comments. I don't think this cleanup is really needed, and assert in that place can give us safe-guard. You may send patch to that list, maybe others will have more comments. Bugzilla is not good for patch review, so I close this one. Thanks.