Bug 19752

Summary:	Update fix for dbus send_destination magic
Product:	PackageKit	Reporter:	Vincent Untz <vuntz>
Component:	General	Assignee:	Richard Hughes <richard>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	scottreeves4
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Vincent Untz 2009-01-26 15:11:54 UTC

I'm not sure the fix that went for this is totally right, but I could be wrong.

http://cgit.freedesktop.org/packagekit/commit/?id=c1daf6f4fe5404b1241a30315687d1d4751b3efb

The policy is now:

  <policy context="default">
    <allow send_interface="org.freedesktop.PackageKit"/>
    <allow send_interface="org.freedesktop.PackageKit.Transaction"/>
    <allow send_destination="org.freedesktop.PackageKit"/>
  </policy>

I believe the first two lines should be removed, or have a send_destination attribute added:

    <allow send_destination="org.freedesktop.PackageKit" send_interface="org.freedesktop.PackageKit"/>
    <allow send_destination="org.freedesktop.PackageKit" send_interface="org.freedesktop.PackageKit.Transaction"/>

Right now, I think it can mean that messages are allowed for services implementing an interface named org.freedesktop.PackageKit.Transaction. You only want this if the destination is org.freedesktop.PackageKit

Feel free to throw me some stone if I'm wrong :-)

Comment 1 Scott Reeves 2009-01-27 11:29:14 UTC

Removed the bare send_interface lines.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.