Bug 21427

Summary: Multifinger detection should be sensed on Z values higher than FingerHigh, not 0
Product: xorg Reporter: Eygene Ryabinkin <rea-xorg>
Component: Input/synapticsAssignee: Peter Hutterer <peter.hutterer>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium CC: egore, rydberg
Version: git   
Hardware: Other   
OS: FreeBSD   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
Patch that changes the lower bound of Z value used for multifinger detection from 0 to FingerHigh
none
0001-PS-2-interface-sense-multifinger-taps-on-FingerHigh.patch none

Description Eygene Ryabinkin 2009-04-26 23:19:07 UTC 
Created attachment 25176 [details] [review]
Patch that changes the lower bound of Z value used for multifinger detection from 0 to FingerHigh

I had run into situation when my taps on the left physical button of Synaptics touchpad ended in a right click.  This was very weird, but debugging revealed that the problem lies in the ClickFinger2 and multifinger detection: value of Z was raising from 0 to 1 or 2, so the code path that translates W values to the number of fingers were activated.  As Synaptics manual suggests, values lower than 10 usually correspond to the fingers situated slightly above touchpad, so this seem to be my case.  And since we're using FingerHigh everywhere to detect touches, it is natural to use this value to detect multifinger clicks.  The attached patch does this and works for me.
Comment 1 Peter Hutterer 2009-04-27 14:41:40 UTC 
Created attachment 25205 [details] [review]
0001-PS-2-interface-sense-multifinger-taps-on-FingerHigh.patch

Rebased patch onto current master.
Comment 2 Peter Hutterer 2009-04-27 14:42:51 UTC 
Henrik, Chris, can I have second ACK please?
Comment 3 Henrik Rydberg 2009-04-27 15:12:43 UTC 
Big ACK, great patch.
Comment 4 Peter Hutterer 2009-04-27 16:53:38 UTC 
Pushed as ef2221322e62b94a88a8358e6513a3f6f232a28f. Thanks for the patch.
Comment 5 Eygene Ryabinkin 2009-04-28 11:15:55 UTC 
Gentlemen, thanks for handling the bug!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.