Bug 21954

Summary: Correct sd_IN locale and add pa_PK locale
Product: xorg Reporter: Parag <panemade>
Component: Lib/Xlib (data)Assignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: medium CC: panemade
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
This patch will correct missing dot in locale.alias.pre for sd_IN locale. Also, will add pa_PK locale information and correct the alignment for second column in locale.alias.pre file.
none
Correct sd_IN locale information
none
This patch will add pa_PK locale information and make pa_IN as default for pa. none

Description Parag 2009-05-26 22:50:22 UTC 
Created attachment 26237 [details] [review]
This patch will correct missing dot in locale.alias.pre for sd_IN locale. Also, will add pa_PK locale information and correct the alignment for second column in locale.alias.pre file.

As of Today's Git checkout of libX11, I found my patch https://bugs.freedesktop.org/attachment.cgi?id=25457 got missed "dot" in locale.alias.pre which made sd_IN failed to work. I am sorry for that.

So I am attaching new patch that corrects sd_IN locale information as well as I also like to add pa_PK locale information in libX11 data.

This patch will also correct the alignment for second column in locale.alias.pre file.
Comment 1 Julien Cristau 2009-05-27 03:47:57 UTC 
On Tue, May 26, 2009 at 22:50:23 -0700, bugzilla-daemon@freedesktop.org wrote:

> Created an attachment (id=26237)
>  --> (http://bugs.freedesktop.org/attachment.cgi?id=26237)
> This patch will correct missing dot in locale.alias.pre for sd_IN locale. Also,
> will add pa_PK locale information and correct the alignment for second column
> in locale.alias.pre file.
> 
Can you please separate these various things in different patches (one
to fix sd_IN, one to add pa_PK, and if you really care one for the
whitespace changes)?  I don't like mixing alignment changes with content
changes.

Thanks,
Julien
Comment 2 Parag 2009-05-27 20:46:14 UTC 
Created attachment 26266 [details] [review]
Correct sd_IN locale information
Comment 3 Parag 2009-05-27 22:53:22 UTC 
Created attachment 26267 [details] [review]
This patch will add pa_PK locale information and make pa_IN as default for pa.
Comment 4 Parag 2009-05-27 22:56:06 UTC 
(In reply to comment #1)
> On Tue, May 26, 2009 at 22:50:23 -0700, bugzilla-daemon@freedesktop.org wrote:
> 
> > Created an attachment (id=26237) [details]
> >  --> (http://bugs.freedesktop.org/attachment.cgi?id=26237)
> > This patch will correct missing dot in locale.alias.pre for sd_IN locale. Also,
> > will add pa_PK locale information and correct the alignment for second column
> > in locale.alias.pre file.
> > 
> Can you please separate these various things in different patches (one
> to fix sd_IN, one to add pa_PK, and if you really care one for the
> whitespace changes)?  I don't like mixing alignment changes with content
> changes.
> 
> Thanks,
> Julien
> 

Ok. It does not matter to have alignment patch submitted here. So, I have submitted 2 different patches.
Comment 5 Julien Cristau 2009-05-29 02:24:13 UTC 
I ended up removing the sd_IN.UTF-8 alias entirely, since I don't think there's any point in aliasing it to itself.  Applied the second patch with a similar change.  Thanks for the patches!

commit e4b0899f516da224010e68bd2d953d5293d94993
Author: parag <parag@rawhideTM.pnq.redhat.com>
Date:   Thu May 28 11:29:35 2009 +0530

    nls: Add pa_PK locale information and make pa_IN as default for pa.
    
    X.Org bug#21954 <http://bugs.freedesktop.org/show_bug.cgi?id=21954>
    
    [jcristau: removed the pa_PK.UTF-8 alias to itself]
    
    Signed-off-by: parag <pnemade@redhat.com>
    Signed-off-by: Julien Cristau <jcristau@debian.org>

commit f0ea1f6d51145592f8617854f9320ec5dbff3299
Author: Julien Cristau <jcristau@debian.org>
Date:   Fri May 29 10:58:20 2009 +0200

    nls: remove broken sd_IN.UTF-8 alias
    
    Signed-off-by: Julien Cristau <jcristau@debian.org>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.