Bug 23228

Summary:	butterfly 0.5.0 fails to compile with python 2.4 in ubuntu karmic
Product:	Telepathy	Reporter:	Alexander Sack <asac>
Component:	butterfly	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED INVALID	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	CC:	lfrb
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	fix syntax for py 2.4

Description Alexander Sack 2009-08-09 12:35:41 UTC

Created attachment 28457 [details] [review]
fix syntax for py 2.4

attaching patch for:

Setting up telepathy-butterfly (0.5.0-0ubuntu2) ...
Compiling /usr/lib/python2.4/site-packages/butterfly/connection.py ...
  File "/usr/lib/python2.4/site-packages/butterfly/connection.py", line 174
    telepathy.CHANNEL_INTERFACE + '.TargetHandle': dbus.UInt32(0 if handle is None else handle.get_id()),
                                                                  ^
SyntaxError: invalid syntax

pycentral: pycentral pkginstall: error byte-compiling files (18)
pycentral pkginstall: error byte-compiling files (18)
dpkg: error processing telepathy-butterfly (--install):
 subprocess installed post-installation script returned error exit status 1
Errors were encountered while processing:
 telepathy-butterfly

Comment 1 Jonny Lamb 2009-08-11 02:01:35 UTC

Hi. Thanks for the patch. If this is the only change required to make butterfly work on python 2.4, then great!

However, your patch is somewhat inconsistent with the butterfly style (why all the unnecessary underscores?). If you could quickly update the patch to use more legible variable names I'll immediately push it.

Thanks.

Comment 2 Louis-Francis Ratté-Boulianne 2009-08-18 11:34:29 UTC

Minimal required version has been bumped to python 2.5 for the next release.

(Papyon depends on python 2.5 anyway)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.