|Summary:||Xft doesn't compute metrics correctly on non-RENDER servers|
|Product:||xorg||Reporter:||Nalin Dahyabhai <nalin.dahyabhai>|
|Component:||Lib/Xft||Assignee:||Keith Packard <keithp>|
|Status:||CLOSED FIXED||QA Contact:|
|i915 platform:||i915 features:|
Description Nalin Dahyabhai 2003-02-13 21:59:54 UTC
If an application calls XftGlyphExtents before attempting to draw a character, libXft assumes that the uninitialized metrics allocated in XftFontCheckGlyph() are valid, causing an abnormally-large XGetImage request to be generated.
Comment 1 Nalin Dahyabhai 2003-02-13 22:00:33 UTC
Created attachment 18 [details] [review] patch to clear metrics and load glyphs correctly
Comment 2 Keith Packard 2003-02-14 12:23:13 UTC
Ah. Your fix masks the real problem. XftFontCheckGlyph isn't supposed to load glyphs; it delays that to batch glyphs together in a single request. Callers are required to also call XftFontLoadGlyphs to actually generate the glyph data. I'll attach a substitute patch which should actually fix this problem.
Comment 3 Keith Packard 2003-02-14 12:24:17 UTC
Created attachment 21 [details] [review] Load missing glyphs before accessing metrics in XftGlyphFontSpecCore
Comment 4 Nalin Dahyabhai 2003-02-14 13:23:10 UTC
I've tested patch in attachment 21 [details] [review] locally, and it fixes the problem.
Comment 5 Mike Harris 2003-02-14 14:24:14 UTC
Confirmed, the problem appears fixed for me too.
Comment 6 Jeremy Huddleston Sequoia 2011-10-01 14:12:00 UTC
Mass update: Close all bugs resolved over one year ago.