Bug 29530

Summary: Fix update notices: not all yum repos are official fedora ones
Product: PackageKit Reporter: Mark J Cox <mjc>
Component: backend-yumAssignee: Richard Hughes <richard>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: Proposed patch
Proposed patch

Description Mark J Cox 2010-08-12 06:02:41 UTC 
Created attachment 37812 [details]
Proposed patch

Currently a hardcoded link pointing to https://admin.fedoraproject.org/updates/ is added to all update notes that have an update_id.  But not all repositories providing updateinfo.xml data and id's are the upstream fedora repositories.  

Ideally the fedora repos would provide the link themselves in a references entity, and I'll add a bz for them to do that, but in the meantime the following patch ensures the link only gets added to updates from the official fedora repo by checking that the 'from' matches 'updates@feodraproject.org'.

I've also moved this logic before parsing other references as this vendor-specific URL is likely the most important (and self) reference.
Comment 1 Mark J Cox 2010-08-12 06:14:11 UTC 
Created attachment 37813 [details] [review]
Proposed patch
Comment 2 Richard Hughes 2010-08-27 15:18:45 UTC 
Committed, thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.