Bug 30448

Summary: The function mcp_account_storage_get_restrictions was redeclared
Product: Telepathy Reporter: Jeff Cai <jeff.cai>
Component: mission-controlAssignee: Simon McVittie <smcv>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: major    
Priority: medium CC: vivek
Version: 5.6Keywords: patch
Hardware: Other   
OS: Solaris   
URL: http://git.collabora.co.uk/?p=user/smcv/telepathy-mission-control-smcv.git;a=shortlog;h=refs/heads/56-type-inconsistency
Whiteboard: review+
i915 platform: i915 features:
Attachments: Change the declaration of the function

Description Jeff Cai 2010-09-29 01:24:15 UTC
Solaris CC reports the following error while building the file account-storage.c:

"account-storage.c", line 754: identifier redeclared: mcp_account_storage_get_restrictions
Comment 1 Jeff Cai 2010-09-29 01:28:36 UTC
Created attachment 39038 [details] [review]
Change the declaration of the function
Comment 2 Simon McVittie 2010-09-29 03:12:43 UTC
Thanks for spotting this. Your patch is technically an API break, so I've done more or less the opposite; we can do the equivalent of your patch instead when we next break the API of m-c-p.

Vivek, please review?
Comment 3 Simon McVittie 2010-10-06 07:16:55 UTC
Fixed in git for 5.6.1

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.