Bug 32027

Summary:	patch to add tiff support to pdftoppm
Product:	poppler	Reporter:	William Bader <williambader>
Component:	splash backend	Assignee:	poppler-bugs <poppler-bugs>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	medium	CC:	williambader
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	patch to add tiff support to pdftoppm New version of tiff patch, against current git source, without outputfilename

Description William Bader 2010-12-01 13:18:27 UTC

Created attachment 40717 [details] [review]
patch to add tiff support to pdftoppm

This patch adds TIFF support to pdftoppm.  It adds a -tiff command line parameter to generate a TIFF file and an optional -tiffcompression parameter to specify the TIFF compression type.
The patch creates a TiffWriter subclass of ImgWriter that calls libtiff.
configure.ac checks for the presence of libtiff and has a --disable-libtiff flag to disable TIFF support.
After applying these patches, you need to run autogen.sh and then a normal make will work.

Comment 1 Albert Astals Cid 2010-12-28 04:14:41 UTC

setOutputFileName is defined but never used?

Comment 2 William Bader 2010-12-28 05:05:09 UTC

Sorry about that.  Thanks for looking at the patch.  You are correct that I never used it.  I was going to set the file name that way, but I ended up setting it in init().

Comment 3 Albert Astals Cid 2010-12-28 05:43:19 UTC

Can you please attach a patch without that unused function and based on current git master?

Comment 4 William Bader 2010-12-28 06:31:42 UTC

Created attachment 41487 [details] [review]
New version of tiff patch, against current git source, without outputfilename

I made a new patch against the current git source.
I removed the unused setOutputFileName() function, and I removed the outputFileName variable since it is always NULL.

Comment 5 Albert Astals Cid 2010-12-29 06:48:07 UTC

Will be in poppler >= 0.17.0

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.