Bug 34321

Summary:	The ARB_fragment_program subset of ARB_draw_buffers not implemented
Product:	Mesa	Reporter:	Marek Olšák <maraeo>
Component:	Mesa core	Assignee:	mesa-dev
Status:	RESOLVED FIXED	QA Contact:
Severity:	major
Priority:	medium	CC:	ansla80, idr, jepler, ojab, sa
Version:	git
Hardware:	x86 (IA32)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:
Bug Depends on:
Bug Blocks:	36182

Description Marek Olšák 2011-02-15 22:19:42 UTC

Hi, I have noticed that the parser for ARB_vertex/fragment_program doesn't implement ARB_draw_buffers. result.color[n] should be allowed if "OPTION ARB_draw_buffers;" is specified. However, when I try to use it like this:

> MOV result.color[0], fragment.texcoord[0];

I get this message:

> Compiler Error (pos=46 line=-1): line 3, char 17: error: syntax error, unexpected '[', expecting ','

I was looking at the code of the parser, but I don't understand a thing in it. This bug can be reproduced with:
piglit/arb_color_buffer_float-mrt

softpipe with ARB_color_buffer_float and ARB_texture_float support, which is required for the piglit test, can be found in this branch:
http://cgit.freedesktop.org/~mareko/mesa/?h=floating2

Comment 1 Eric Anholt 2011-04-13 18:10:14 UTC

commit 28cec9e832b716b84c11ddabfcee74e0daf6ec49
Author: Eric Anholt <eric@anholt.net>
Date:   Wed Apr 13 11:09:55 2011 -0700

    mesa: Add support for the ARB_fragment_program part of ARB_draw_buffers.
    
    Fixes fbo-drawbuffers-arbfp.
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=34321
    Reviewed-by: Brian Paul <brianp@vmware.com>
    Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.