Bug 4066

Summary: I830 IO unresolved symbols in i810 driver
Product: xorg Reporter: Joshua Baergen <joshuabaergen>
Component: Build/ModularAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: high CC: battousai, dberkholz, gentoo
Version: 6.7.0   
Hardware: x86 (IA32)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
xf86-video-i810-1.4.0-Makefile.am.patch none

Description Joshua Baergen 2005-08-13 13:47:17 UTC 
The i810 driver uses a lot of i830 driver code but does not by default define
the necessary symbols for the i830 driver to function.  The attached patch below
adds the necessary define to Makefile.am in xf86-video-i810/src/ to enable the
relevant defines.  After i830_shadow.c is added (previous bug) and this patch is
applied the i810 driver appears to function normally.
Comment 1 Joshua Baergen 2005-08-13 13:50:15 UTC 
Created attachment 3338 [details]
Screenshot of the corruption

Adds -DBUILD_FOR_I830 required for the defines in i810_io.c to resolve externs
in i830.h used in i830_driver.c .
Comment 2 Donnie Berkholz 2005-08-20 13:13:34 UTC 
Josh, could you reattach the patch? Bugzilla crashed and lost it.
Comment 3 Joshua Baergen 2005-08-22 17:32:06 UTC 
Created attachment 2999 [details] [review]
xf86-video-i810-1.4.0-Makefile.am.patch

Sorry for the delay, had a busy weekend.  Thanks for the heads-up.
Comment 4 Kristian Høgsberg 2005-09-02 09:21:31 UTC 
I think that patch will break the driver for i810, but the fix that's in cvs
should make it work for both i810 and i830.  Could you give that a try, and
close the bug if it works for you?  Thanks.
Comment 5 Joshua Baergen 2005-09-02 13:05:54 UTC 
Actually my patch works fine on the 810 (what I'm using).  The 810 appears to
make extensive reference to 830 calls and this might be why it works.

I'll try CVS now and let you know.
Comment 6 Joshua Baergen 2005-09-02 13:25:43 UTC 
Ah, I see this now depends on XvMC.  Will XvMC support be optional in the future?
Comment 7 Joshua Baergen 2005-09-02 14:14:35 UTC 
Confirmed that this is now fixed.  An answer to comment #6 would still be
appreciated ;D

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.