|Summary:||ytstenut-glib doesn't build with mingw32|
|Product:||Ytstenut||Reporter:||Siraj Razick <siraj>|
|Component:||ytstenut-glib||Assignee:||Robert Staudinger <robert.staudinger>|
|Status:||RESOLVED FIXED||QA Contact:|
|Priority:||medium||CC:||olli.salli, robert.staudinger, siraj|
|i915 platform:||i915 features:|
Description Siraj Razick 2012-01-03 18:03:57 UTC
current master doesn't cross compile with mingw32 SDK
Comment 1 Siraj Razick 2012-01-03 18:34:42 UTC
patch with build fixes
Comment 2 Olli Salli 2012-01-25 11:01:40 UTC
Patch looks ok. Use keywords field instead of whiteboard for "patch" please, bugzilla has a special meaning for that field.
Comment 3 Robert Staudinger 2012-02-02 00:36:49 UTC
Patch looks good, so this is only about nit picking. +#Check operating system There's no need for that comment, the code makes it pretty clear. +AC_MSG_CHECKING([operating system]) Please use AC_MSG_CHECKING([for operating system]) +case "$host" in + *-*-*mingw*|*-*-*cygwin*) + platform=win32 + AC_MSG_RESULT($platform) + ;; + *) + platform=linux/other Let's call that platform "generic" please. + AC_MSG_RESULT($platform) + ;; +esac Let's just have one AC_MSG_RESULT after the switch please. +AM_CONDITIONAL([WINDOWS], [test "$platform" = "win32"] Please call that conditional PLATFORM_WINDOWS or OS_WINDOWS. +if test "$platform" = "win32" +then Please stick to the formatting: "if foo; then" on a single line Thanks
Comment 4 Siraj Razick 2012-02-02 09:13:52 UTC
patch updated, and re tested on linux and windows. Patch is not rebased since fdo is down :(. if it conflicts really badly please reassign it to me, I'll be happy to resolve the conflicts.
Comment 5 Robert Staudinger 2012-02-02 13:34:08 UTC
Thanks kindly commit 2916018392df240d98fe00dc9e1c08b2547aeb5f Author: Siraj Razick <firstname.lastname@example.org> Date: Tue Jan 3 20:59:36 2012 -0500 Build fixes for Mingw32 These changes enables us to cross-compile ytstenut-glib for windows with mingw32.