|Summary:||gnome-shell does not show correct user name or profile picture|
|Product:||accountsservice||Reporter:||Giovanni Campagna <scampa.giovanni>|
|Component:||general||Assignee:||Matthias Clasen <mclasen>|
|Status:||RESOLVED FIXED||QA Contact:|
|i915 platform:||i915 features:|
UserManager: fix advancing seat loading state machine
ActUser: set loaded status even if an error occurs
ActUser: use -1 to indicate default DBus timeout
Description Giovanni Campagna 2012-02-29 13:20:54 UTC
Ok, that was the net outcome. After some analysis, I found three small bugs in libaccountsservice, in how the state machine for is-loaded is advanced as data arrives from the bus. I hope that the patches are clear enough. They fix the visibile part of the bug here.
Comment 1 Giovanni Campagna 2012-02-29 13:21:40 UTC
Created attachment 57828 [details] [review] UserManager: fix advancing seat loading state machine Because the session proxy creating happened synchronously, seat loading state was incremented, but nothing called load_seat_incrementally() again, meaning that it never advanced to next step. Making it async like the other operations fixes it.
Comment 2 Giovanni Campagna 2012-02-29 13:21:53 UTC
Created attachment 57829 [details] [review] ActUser: set loaded status even if an error occurs Not doing so confuses the UserManager, which still considers the user pending and blocks the emission of user-added/user-removed signals.
Comment 3 Giovanni Campagna 2012-02-29 13:22:03 UTC
Created attachment 57830 [details] [review] ActUser: use -1 to indicate default DBus timeout Passing 0 means 0 milliseconds, which is quite too short even on modern computers.
Comment 4 Ray Strode [halfline] 2012-03-15 16:41:15 UTC