Bug 52782

Summary: config error messages for shared properties
Product: SyncEvolution Reporter: SyncEvolution Community <syncevolution-issues>
Component: SyncEvolutionAssignee: SyncEvolution Community <syncevolution-issues>
Status: RESOLVED MOVED QA Contact:
Severity: enhancement    
Priority: low CC: syncevolution-issues
Version: unspecified   
Hardware: All   
OS: All   
Whiteboard:
i915 platform: i915 features:

Description Patrick Ohly 2012-07-29 18:36:00 UTC


---- Reported by jingke.zhang@intel.com 2010-04-13 20:20:44 +0000 ----

This is from http://bugzilla.moblin.org/show_bug.cgi?id=8037

   Description  From  pohly   2009-11-16 01:59:24 PST   (-) [reply]

Error messages for invalid properties contain the name of the config file in
which they would be stored:

- create config
- set invalid "sync" property via text editor (command line rejects invalid
values)
- syncevolution --print-config

=> 

# requests a certain synchronization mode:
#   two-way             = only send/receive changes since last sync
#   slow                = exchange all items
#   refresh-from-client = discard all remote items and replace with
#                         the items on the client
#   refresh-from-server = discard all local items and replace with
#                         the items on the server
#   one-way-from-client = transmit changes from client
#   one-way-from-server = transmit changes from server
#   none (or disabled)  = synchronization disabled
[ERROR]
/home/pohly/.config/syncevolution/foobar/sources/addressbook/config.ini: sync =
invalid-sync-value: not one of the valid values (two-way, slow,
refresh-from-client = refresh-client, refresh-from-server = refresh-server =
refresh, one-way-from-client = one-way-client, one-way-from-server =
one-way-server = one-way, disabled = none)

After implementing the revised config handling (https://bugs.meego.com/show_bug.cgi?id=7707), the file name is
always the name of the non-shared properties. If the wrong property was one of
the shared ones, the user would look into the wrong file.

Right now this cannot happen because none of the shared properties have invalid
values.

The fix for this is to change the ConfigNode::getName() API so that it is
passed a property name. Then MultiplexConfigNode can look up the right name in
the nodes that it accesses.



--- Bug imported by patrick.ohly@gmx.de 2012-07-29 20:36 UTC  ---

This bug was previously known as _bug_ 713 at https://bugs.meego.com/show_bug.cgi?id=713
Comment 1 GitLab Migration User 2018-10-13 12:40:29 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/SyncEvolution/syncevolution/issues/44.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.