Bug 53047

Summary:	Moving cursor crashes weston
Product:	Wayland	Reporter:	Harri Nieminen <moikkis>
Component:	weston	Assignee:	Wayland bug list <wayland-bugs>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	x86-64 (AMD64)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:
Attachments:	Patch

Description Harri Nieminen 2012-08-01 15:04:51 UTC

I'm running weston under X in xmonad. 
Weston does crash when I'm moving cursor near border of weston window.

using: 
weston: d9a8e16b7b271ed4113987846360275c102c8527
wayland: 7f3d22776bc74d7deae0966681ed176363ea1781

Here is gdb bt of crash.

(gdb) bt
#0  clip_pointer_motion (fy=<synthetic pointer>, fx=<synthetic pointer>, seat=<optimized out>) at compositor.c:1687
#1  notify_motion (seat=<optimized out>, time=3803191347, x=136960, y=163840) at compositor.c:1711
#2  0x00007ffff442db00 in x11_compositor_handle_event (fd=<optimized out>, mask=0, data=0x621ed0) at compositor-x11.c:883
#3  0x00007ffff7bd354b in post_dispatch_check (loop=0x622c90) at event-loop.c:376
#4  wl_event_loop_dispatch (loop=0x622c90, timeout=<optimized out>) at event-loop.c:416
#5  0x000000000040c813 in weston_output_repaint (msecs=-491775952, output=0x91cff0) at compositor.c:1176
#6  weston_output_finish_frame (output=0x91cff0, msecs=-491775952) at compositor.c:1210
#7  0x00007ffff442d4c5 in finish_frame_handler (data=<optimized out>) at compositor-x11.c:354
#8  0x00007ffff7bd2e13 in wl_event_source_timer_dispatch (source=0x8e50a0, ep=<optimized out>) at event-loop.c:173
#9  0x00007ffff7bd34f8 in wl_event_loop_dispatch (loop=0x61a9a0, timeout=<optimized out>) at event-loop.c:410
#10 0x00007ffff7bd167d in wl_display_run (display=0x61a950) at wayland-server.c:1103
#11 0x0000000000407362 in main (argc=<optimized out>, argv=<optimized out>) at compositor.c:3576

Comment 1 lukash 2012-09-08 14:54:05 UTC

Created attachment 66847 [details] [review]
Patch

Happens to me too under X with awesome WM. Attached patch fixes it, though I'm not sure about its correctness.

Comment 2 Harri Nieminen 2012-09-12 15:03:39 UTC

(In reply to comment #1)
> Created attachment 66847 [details] [review] [review]
> Patch
> 
> Happens to me too under X with awesome WM. Attached patch fixes it, though I'm
> not sure about its correctness.

This patch fixes my problem.

Comment 3 Kristian Høgsberg 2012-10-29 18:11:14 UTC

Fixed by:


commit 00fbbe6b6038553068cd9d903d96c7ba441a01c6
Author: Kristian Høgsberg <krh@bitplanet.net>
Date:   Tue Oct 23 13:04:09 2012 -0400

    compositor: Clip pointer coordinates on pointer enter as well
    
    When tiling window managers resize a non-resizable window they're violating
    ICCCM.  Not some hippie-community standard like EWMH, but ICCCM, which is
    about as old and sacred as the constitution.  If they want to force a window
    to be a size it wasn't designed for, at least they could have the decency to
    reparent the client window into a bigger containing window of whatever size
    they think it should be.  But apparently ICCCM compliance is too much to ask
    
    Anyway, all that just to say that it's really not our fault when we get an
    enter event with coordinates outside the valid output region.  But we'll
    clip it anyway and work around mis-behaving tiling WMs.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.