Bug 5613

Summary: Xorg 7.0 support for the Hurd
Product: xorg Reporter: Samuel Thibault <samuel.thibault>
Component: * OtherAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: high    
Version: 7.0.0   
Hardware: x86 (IA32)   
OS: other   
Whiteboard:
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 6666    
Attachments:
Description Flags
puts back Hurd support for Xorg 7.0
none
updated patch for putting back Hurd support for Xorg 7.0
none
updated patch for putting back Hurd support for Xorg 7.0
none
some Linuxism fixes
none
missing parts
none
link failure on Hurd with current git
none
Hurd fixups
none
Hurd & freeBSD fixups none

Description Samuel Thibault 2006-01-16 11:17:57 UTC
Hi,

Xorg 7.0 dropped support for the Hurd.  Here is a patch that puts it back.  Xorg 7.0 then compiles and runs fine.

Regards,
Samuel
Comment 1 Samuel Thibault 2006-01-16 11:21:27 UTC
Created attachment 4360 [details] [review]
puts back Hurd support for Xorg 7.0

BTW, could a "GNU Hurd" operating system type be added to the BTS?
Comment 2 Samuel Thibault 2006-03-11 10:51:04 UTC
Created attachment 4895 [details] [review]
updated patch for putting back Hurd support for Xorg 7.0

The only difference with the previous one is a AT scancode translation fixup.
Comment 3 Samuel Thibault 2006-03-11 10:54:01 UTC
Created attachment 4896 [details] [review]
updated patch for putting back Hurd support for Xorg 7.0

Oops, sorry, rediff wasn't done.
Comment 4 Daniel Stone 2006-08-12 09:42:13 UTC
fixed in git master, thanks for the patch
Comment 5 Samuel Thibault 2006-08-20 09:54:26 UTC
Mmm, in the meanwhile, some Linux-isms have appeared, here is a patch
Comment 6 Samuel Thibault 2006-08-20 09:55:11 UTC
Created attachment 6622 [details] [review]
some Linuxism fixes
Comment 7 Samuel Thibault 2006-08-20 12:50:18 UTC
Created attachment 6625 [details] [review]
missing parts

Mmm, some part of the patch actually didn't get applied, here it is again (it
is really needed for getting keyboard working).
Comment 8 Samuel Thibault 2006-08-20 12:51:29 UTC
*** Bug 5537 has been marked as a duplicate of this bug. ***
Comment 9 Daniel Stone 2006-08-20 15:17:42 UTC
(In reply to comment #7)
> Mmm, some part of the patch actually didn't get applied, here it is again (it
> is really needed for getting keyboard working).

er, did you test that?  the os keyboard layer is only used by the deprecated
keyboard driver (i.e. not kbd), which hasn't been enabled since about 6.8.2, iirc.
Comment 10 Samuel Thibault 2006-08-20 15:52:22 UTC
Yes: without this, I get undefined Kbd symbols. Or maybe I'm missing some magic stuff elsewhere, but in any case, the system-specific ioctl()s performed in KbdOn, KbdOff and KbdEvent need to be done somewhere.
Comment 11 Samuel Thibault 2006-08-26 12:42:47 UTC
Created attachment 6707 [details]
link failure on Hurd with current git
Comment 12 Samuel Thibault 2006-08-26 12:45:00 UTC
I've attached the link failure that I'm seeing.

Note that the last hook of of my "missing parts" patch is needed anyway: @SERVER_DEFINES@ and @LOADER_DEFINES@ are not defined any more.
Comment 13 Samuel Thibault 2006-11-03 07:47:11 UTC
Hi,

Ah, I hadn't seen that you had committed hurd keyboard stuff in the xf86-input-keyboard driver. I'll see how to correct things there.

Samuel
Comment 14 Samuel Thibault 2006-11-03 15:46:55 UTC
Created attachment 7643 [details] [review]
Hurd fixups

Hi again,

Ok, here is an updated patch with which the X server seems to work fine since
the keyboard stuff is indeed in the input-keyboard module. It includes

- byteswap.h inclusion fixup (the Hurd has it just like linux)
- disabling kdrive/linux/ compiling on systems others that linux
- bell (non-)support
- mouse cleanup: the generic MouseProc is just fine.

Could this go to server-1.2-branch?

Thanks for putting back Hurd stuff!
Comment 15 Daniel Stone 2006-11-04 09:10:11 UTC
thanks a lot, i've pushed these to master.  leaving this bug open though, until
i push hurd_{kbd,io}.c to server-1.2-branch.
Comment 16 Daniel Stone 2006-12-16 09:41:52 UTC
pushed to 1.2 branch
Comment 17 Samuel Thibault 2006-12-17 13:17:20 UTC
Created attachment 8150 [details] [review]
Hurd & freeBSD fixups

Thanks for the push, and sorry to bother again, but some fixups are still
missing from the 1.2 branch, here is a patch (backported from master)
Comment 18 Samuel Thibault 2006-12-17 13:18:05 UTC
See comments of latest patch.
Comment 19 Daniel Stone 2006-12-23 20:32:41 UTC
okay, pushed this last bit too, thanks for your patience

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.