Summary: | Allow build outside source tree | ||
---|---|---|---|
Product: | dbus | Reporter: | Bernard Leak <bernard> |
Component: | core | Assignee: | Havoc Pennington <hp> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | enhancement | ||
Priority: | high | CC: | bernard |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | |||
i915 platform: | i915 features: | ||
Bug Depends on: | |||
Bug Blocks: | 7813 | ||
Attachments: |
Allow build outside the source directory: the CVS sources patch
Allow build outside the source directory: the release extra patch Allow build outside the source directory: the release extra patch CVS sources patch, without the mistaken hunk |
Description
Bernard Leak
2006-02-26 00:12:01 UTC
Created attachment 4746 [details] [review] Allow build outside the source directory: the CVS sources patch Created attachment 4747 [details] [review] Allow build outside the source directory: the release extra patch Created attachment 4749 [details] [review] Allow build outside the source directory: the release extra patch Comment on attachment 4746 [details] [review] Allow build outside the source directory: the CVS sources patch You change dbus-viewer to be found in top_srcdir, but it's a compiled object; does libtool want the srcdir name or something? Looks fine to me, assuming it works and make distcheck still works. The relocation of dbus-viewer was my mistake. The dbus test fails for me for other reasons (I get multiple assertion failures at dbus-signature.c line 192). This change was added on autopilot and left in by oversight. This is now the only failing test I see: I'll look into it a bit harder. Created attachment 4814 [details] [review] CVS sources patch, without the mistaken hunk The dbus test still fails for me. I get the same assertion failure as before, with no visible difference between builddir=srcdir (unpatched sources) and builddir != srcdir (new sources). I've removed the hunk which made the script look for dbus-viewer in the source tree - I agree that was a mistake. I've checked the others, and they all still look all right. I'm wondering if this is still an issue as we did some fixes. Putting on thr 1.0 blocker. Picked a few pieces out of this patch and applied it to head. Thanks. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.