| Summary: | Cleanup internal passing of credentials and options | ||
|---|---|---|---|
| Product: | realmd | Reporter: | Stef Walter <stefw> |
| Component: | General | Assignee: | Stef Walter <stefw> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | stefw, yelley |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Bug Depends on: | 56022 | ||
| Bug Blocks: | 54489, 60637, 60679, 61215 | ||
| Attachments: |
Cleanup passing around of credentials during join/leave operations
More extensible passing of options to join/leave implementations Pass 'realm join' options in a structure More extensible passing of options to join/leave implementations Cleanup passing around of credentials during join/leave operations More extensible passing of options to join/leave implementations Cleanup passing around of credentials during join/leave operations |
||
|
Description
Stef Walter
2013-04-11 15:46:53 UTC
Created attachment 77820 [details] [review] Cleanup passing around of credentials during join/leave operations Created attachment 77821 [details] [review] More extensible passing of options to join/leave implementations Created attachment 77822 [details] [review] Pass 'realm join' options in a structure Yassir, are you interested in reviewing these? Created attachment 77849 [details] [review] More extensible passing of options to join/leave implementations This update fixes a bug that this patch introduced in handle_deconfigure() Created attachment 77869 [details] [review] Cleanup passing around of credentials during join/leave operations Fixed an assertion that occurred when using ChangeLoginPolicy() since it's a method without any credetnials. Created attachment 77879 [details] [review] More extensible passing of options to join/leave implementations Updated patch to always lower case realm names used as section headers Created attachment 78451 [details] [review] Cleanup passing around of credentials during join/leave operations Updated the patch to fix some mistakes in realm-sssd-ipa.c Attachment 77822 [details] pushed as 3a0a8e6 - Pass 'realm join' options in a structure Attachment 77879 [details] pushed as 1a7215e - More extensible passing of options to join/leave implementations Attachment 78451 [details] pushed as 5c6917b - Cleanup passing around of credentials during join/leave operations Unfortunately review timed out on these patches, and other patches depend on them for the upcoming test day. I've run these patches through their paces, reviewed them again, found some bugs and tweaks. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.