Bug 70965

Summary: Build system fixes for static linking
Product: nice Reporter: Philip Withnall <bugzilla>
Component: GeneralAssignee: Dafydd Harries <dafydd.harries>
Status: RESOLVED FIXED QA Contact:
Severity: major    
Priority: medium CC: bugzilla, olivier.crete
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: build: Add ‘-I m4’ to ACLOCAL_AMFLAGS
build: Add AM_PROG_AR to configure.ac
build: Update configure.ac according to autoupdate
build: Add GUPnP libraries to Libs.private in pkg-config file

Description Philip Withnall 2013-10-28 17:56:11 UTC
A few patches coming up to fix static linking against libnice.
Comment 1 Philip Withnall 2013-10-28 18:01:19 UTC
Created attachment 88239 [details] [review]
build: Add ‘-I m4’ to ACLOCAL_AMFLAGS
Comment 2 Philip Withnall 2013-10-28 18:01:35 UTC
Created attachment 88240 [details] [review]
build: Add AM_PROG_AR to configure.ac
Comment 3 Philip Withnall 2013-10-28 18:01:50 UTC
Created attachment 88241 [details] [review]
build: Update configure.ac according to autoupdate
Comment 4 Philip Withnall 2013-10-28 18:02:02 UTC
Created attachment 88242 [details] [review]
build: Add GUPnP libraries to Libs.private in pkg-config file
Comment 5 Philip Withnall 2013-10-28 18:02:50 UTC
(Only the fourth patch fixes the linking problems. The other three are just general cleanup.)
Comment 6 Olivier Crête 2013-10-29 16:43:54 UTC
Merged!

commit 3e12ed2feb4edde26d4a09d8e9170051c5d3582a
Author: Philip Withnall <philip.withnall@collabora.co.uk>
Date:   Mon Oct 28 17:53:29 2013 +0000

    build: Add GUPnP libraries to Libs.private in pkg-config file
    
    They’re private dependencies which are needed on the linker command line when
    linking statically against libnice.
    
    https://bugs.freedesktop.org/show_bug.cgi?id=70965

commit 6c900953600cd955a84d4c20f573a0c29e76100e
Author: Philip Withnall <philip.withnall@collabora.co.uk>
Date:   Mon Oct 28 13:33:57 2013 +0000

    build: Update configure.ac according to autoupdate
    
    https://bugs.freedesktop.org/show_bug.cgi?id=70965

commit 1432e9aec3a72c5d88d0a87e6865b19824065c52
Author: Philip Withnall <philip.withnall@collabora.co.uk>
Date:   Mon Oct 28 13:30:26 2013 +0000

    build: Add AM_PROG_AR to configure.ac
    
    This shuts up an automake warning about needing it when using a non-POSIX
    archiver.
    
    https://bugs.freedesktop.org/show_bug.cgi?id=70965

commit 20ac9b54dd3d55ec8997048ac9d97c4ffca5a5d8
Author: Philip Withnall <philip.withnall@collabora.co.uk>
Date:   Mon Oct 28 13:29:52 2013 +0000

    build: Add ‘-I m4’ to ACLOCAL_AMFLAGS
    
    This shuts up an automake warning and ensures that in-tree m4 macros are found
    by aclocal.
    
    https://bugs.freedesktop.org/show_bug.cgi?id=70965

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.