| Summary: | Do not regenerate cairo-features.h on each configure run | ||
|---|---|---|---|
| Product: | cairo | Reporter: | Yevgen Muntyan <muntyan> |
| Component: | general | Assignee: | Carl Worth <cworth> |
| Status: | RESOLVED FIXED | QA Contact: | cairo-bugs mailing list <cairo-bugs> |
| Severity: | normal | ||
| Priority: | high | ||
| Version: | 1.1.8 | ||
| Hardware: | x86 (IA32) | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
patch
another patch |
||
|
Description
Yevgen Muntyan
2006-06-15 01:37:02 UTC
Created attachment 5915 [details] [review] patch Unortunately I could not do 'make distcheck' because "52 of 87 tests failed". Why distcheck does that anyway? Created attachment 5916 [details] [review] another patch It passes 'make distcheck'; the generated file doesn't get into tarball; it gets generated in a fresh tarball (and in not-fresh source dir too, of course); i.e. seems to be working. I don't see the benefit of doing it in the Makefile. It just needs to not recreate if the contents are not changed, but that can be done in configure. I'm actually getting rid of cairo-features.h.in template... Just doing it the configure script sounds great to me. I wouldn't care if this were with a .in template plus a conditional copy or if the file were just generated "manually", (which would have the nice side effect of getting rid of the ugly blank lines currently in cairo-features.h). -Carl Committed. commit f71313d427565cb37a25393ff8a5a2ffdcfb798b Author: Behdad Esfahbod <behdad@behdad.org> Date: Wed Jun 21 07:00:34 2006 -0400 Minor refinements, mostly to configure.in. commit c88bab66ab258e0bbd2cb80eaf4edc9e5f1ad6f0 Author: Behdad Esfahbod <behdad@behdad.org> Date: Wed Jun 21 06:25:01 2006 -0400 Make configure generate cairo-features.h. Generate AC_DEFINE and AM_CONDITIONALS for all CAIRO_HAS_* in CAIRO_BACKEND_ENABLE. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.