Bug 73016

Created attachment 91183 [details] [review]
Adjust the default value for contrast/saturation

Could you giva a try to the patch ?

I applied the patch and it didn't work. Colors were still incorrect.

Could you attach the output of 'lspci -nn', I want to know what is your HW.

Your are using mplayer-vaapi, right ? Can you get the right color if running the following command:

mplayer -vo vaapi -brightness 0  -contrast 0 -hue 0 -saturation 0 <video file>

Created attachment 91206 [details]
hardware

output of lscpi -nn

I am using mplayer-vaapi; the mplayer command didn't change the color issue.

I can reproduce this error on sandybridge and ironlake hardware (it's all I use).

I can reproduce the issue on Sandybridge, but after applying the patch, the issue disappears.  Could you double-check whether the right driver is used ?

Created attachment 91208 [details] [review]
disable color balance temporarily on Sandybridge

The patch disables color balance totally on Sandybridge, it is only for testing. Can you get the right color after apply this patch ?

I have tested your patch and the color is still messed up.

I have checked the driver and I am sure it's the right one. See below for the output of vainfo :

libva info: VA-API version 0.34.0
libva info: va_getDriverName() returns 0
libva info: Trying to open /usr/lib/dri/i965_drv_video.so
libva info: Found init function __vaDriverInit_0_34
libva info: va_openDriver() returns 0
vainfo: VA-API version: 0.34 (libva 1.2.1)
vainfo: Driver version: Intel i965 driver - 1.2.2
vainfo: Supported profile and entrypoints
      VAProfileNone                   :	VAEntrypointVideoProc
      VAProfileMPEG2Simple            :	VAEntrypointVLD
      VAProfileMPEG2Main              :	VAEntrypointVLD
      VAProfileH264Main               :	VAEntrypointVLD
      VAProfileH264High               :	VAEntrypointVLD
      VAProfileH264ConstrainedBaseline:	VAEntrypointVLD

Can you reproduce the issue with 1.2.1 ?

http://www.freedesktop.org/software/vaapi/releases/libva-intel-driver/libva-intel-driver-1.2.1.tar.bz2

Annual Leave on Dec.30/31, 2013. Please expect delayed email response.

No, mplayer-vaapi 1.2.1 doesn't have the color issue.

Created attachment 91312 [details] [review]
Bypass color balance transformation in another way

The patch bypasses color balance in another way and changes the version information as well.  I am pretty sure the issue is caused by color balance in vaPutSurface().   Could you help to check the following questions after applying the patch ?

1.  Is the driver version shown by vainfo 1.2.3.pre1 ?

2.  Do vainfo and mplayer show the same driver path ?

I have no idea about the issue if the above patch still doesn't work for you :(. Because this is a regression, could you help to do a bisect between 1.2.1 and 1.2.2 to find the bad commit ?

You my good buddy are a treasure! Your patch worked and the color seems fine now! Here's the output of my vainfo:

vainfo: VA-API version: 0.34 (libva 1.2.1)
vainfo: Driver version: Intel i965 driver - 1.2.3.pre1
vainfo: Supported profile and entrypoints
      VAProfileNone                   :	VAEntrypointVideoProc
      VAProfileMPEG2Simple            :	VAEntrypointVLD
      VAProfileMPEG2Main              :	VAEntrypointVLD
      VAProfileH264Main               :	VAEntrypointVLD
      VAProfileH264Main               :	VAEntrypointEncSlice
      VAProfileH264High               :	VAEntrypointVLD
      VAProfileH264High               :	VAEntrypointEncSlice
      VAProfileVC1Simple              :	VAEntrypointVLD
      VAProfileVC1Main                :	VAEntrypointVLD
      VAProfileVC1Advanced            :	VAEntrypointVLD
      VAProfileH264ConstrainedBaseline:	VAEntrypointVLD
      VAProfileH264ConstrainedBaseline:	VAEntrypointEncSlice

I just figured out a big issue that's not related to vaapi. The makepkg script in Arch Linux was not reporting that patches were properly applied so the first patch didn't work. I identified this issue and successfully applied the second patch. Now that I've applied the first patch; it works too! I apologize for the inconvenience; thanks for the help!

commit 54cb60f3d973ce6a908ea57f5aa7481803fe653a
Author: Xiang, Haihao <haihao.xiang@intel.com>
Date:   Mon Dec 30 13:15:40 2013 +0800

    Render: Adjust the default value for contrast/saturation
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=73016
    Signed-off-by: Xiang, Haihao <haihao.xiang@intel.com>
    Tested-by: Mark Lee <mark@markelee.com>