Bug 74165

Summary: xf86-video-intel xwayland branch fails to build
Product: Wayland Reporter: Aaron Paden <aaronbpaden>
Component: XWaylandAssignee: Wayland bug list <wayland-bugs>
Status: RESOLVED WONTFIX QA Contact: Xorg Project Team <xorg-team>
Severity: blocker    
Priority: medium    
Version: unspecified   
Hardware: x86-64 (AMD64)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:

Description Aaron Paden 2014-01-28 22:51:46 UTC
I get the following errors building in jhbuild:

sna_display.c: In function 'sna_mode_disable_shadow':
sna_display.c:850:2: warning: passing argument 1 of 'DamageUnregister' from incompatible pointer type [enabled by default]
  DamageUnregister(&sna->front->drawable, sna->mode.shadow_damage);
  ^
In file included from /opt/jhbuild-gnome/include/xorg/pixmapstr.h:53:0,
                 from /opt/jhbuild-gnome/include/xorg/xf86str.h:40,
                 from /opt/jhbuild-gnome/include/xorg/xf86.h:44,
                 from /opt/jhbuild-gnome/include/xorg/xf86i2c.h:9,
                 from /opt/jhbuild-gnome/include/xorg/xf86DDC.h:16,
                 from sna_display.c:46:
/opt/jhbuild-gnome/include/xorg/damage.h:77:2: note: expected 'DamagePtr' but argument is of type 'struct DrawableRec *'
  DamageUnregister(DamagePtr pDamage);
  ^
sna_display.c:850:2: error: too many arguments to function 'DamageUnregister'
  DamageUnregister(&sna->front->drawable, sna->mode.shadow_damage);
  ^
In file included from /opt/jhbuild-gnome/include/xorg/pixmapstr.h:53:0,
                 from /opt/jhbuild-gnome/include/xorg/xf86str.h:40,
                 from /opt/jhbuild-gnome/include/xorg/xf86.h:44,
                 from /opt/jhbuild-gnome/include/xorg/xf86i2c.h:9,
                 from /opt/jhbuild-gnome/include/xorg/xf86DDC.h:16,
                 from sna_display.c:46:
/opt/jhbuild-gnome/include/xorg/damage.h:77:2: note: declared here
  DamageUnregister(DamagePtr pDamage);
  ^
Makefile:585: recipe for target 'sna_display.lo' failed
make[4]: *** [sna_display.lo] Error 1
make[4]: *** Waiting for unfinished jobs....
sna_accel.c: In function 'sna_poly_zero_line_blt':
sna_accel.c:7629:11: warning: variable 'intersects' set but not used [-Wunused-but-set-variable]
      bool intersects;
           ^
sna_accel.c:7528:7: warning: variable 'degenerate' set but not used [-Wunused-but-set-variable]
  bool degenerate = true;
       ^
sna_accel.c: In function 'migrate_dirty_tracking':
sna_accel.c:15226:3: warning: passing argument 1 of 'DamageUnregister' from incompatible pointer type [enabled by default]
   DamageUnregister(&dirty->src->drawable, dirty->damage);
   ^
In file included from /opt/jhbuild-gnome/include/xorg/pixmapstr.h:53:0,
                 from /opt/jhbuild-gnome/include/xorg/xf86str.h:40,
                 from /opt/jhbuild-gnome/include/xorg/xf86.h:44,
                 from ../../src/intel_options.h:4,
                 from sna_accel.c:32:
/opt/jhbuild-gnome/include/xorg/damage.h:77:2: note: expected 'DamagePtr' but argument is of type 'struct DrawableRec *'
  DamageUnregister(DamagePtr pDamage);
  ^
sna_accel.c:15226:3: error: too many arguments to function 'DamageUnregister'
   DamageUnregister(&dirty->src->drawable, dirty->damage);
   ^
In file included from /opt/jhbuild-gnome/include/xorg/pixmapstr.h:53:0,
                 from /opt/jhbuild-gnome/include/xorg/xf86str.h:40,
                 from /opt/jhbuild-gnome/include/xorg/xf86.h:44,
                 from ../../src/intel_options.h:4,
                 from sna_accel.c:32:
/opt/jhbuild-gnome/include/xorg/damage.h:77:2: note: declared here
  DamageUnregister(DamagePtr pDamage);
  ^

I wasn't sure if it was more appropriate to report this for xwayland or xorg, but this is my best guess.
Comment 1 Kristian Høgsberg 2014-04-03 17:17:39 UTC
Xwayland is changing to be a standalone X server and won't need changes to Xorg DDX drivers anymore.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.