| Summary: | [SKL Regression]many kms_flip and kms_cursor_crc subcases cause [drm:check_crtc_state [i915]] *ERROR* mismatch in dpll_hw_state.ctrl1 (expected 0x00000000, found 0x00000001) | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | DRI | Reporter: | lu hua <huax.lu> | ||||||
| Component: | DRM/Intel | Assignee: | Ander Conselvan de Oliveira <conselvan2> | ||||||
| Status: | CLOSED FIXED | QA Contact: | Intel GFX Bugs mailing list <intel-gfx-bugs> | ||||||
| Severity: | critical | ||||||||
| Priority: | highest | CC: | intel-gfx-bugs, james.ausmus | ||||||
| Version: | unspecified | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux (All) | ||||||||
| Whiteboard: | |||||||||
| i915 platform: | i915 features: | ||||||||
| Attachments: |
|
||||||||
|
Description
lu hua
2015-05-15 05:20:58 UTC
kms_cursor_crc also has this error. kms_plane and kms_psr_sink_crc also have this error. More than 100 cases have this error. pm_rpm also has this error. Created attachment 115798 [details] [review] Possible fix Could you test if the attached patch fixes the issue? (In reply to Ander Conselvan de Oliveira from comment #4) > Created attachment 115798 [details] [review] [review] > Possible fix > > Could you test if the attached patch fixes the issue? Apply this patch, build fail. CC [M] drivers/infiniband/hw/ipath/ipath_wc_x86_64.o CC [M] drivers/infiniband/ulp/ipoib/ipoib_main.o CC [M] drivers/infiniband/ulp/iser/iser_verbs.o CC [M] drivers/infiniband/ulp/iser/iser_initiator.o CC [M] drivers/infiniband/ulp/iser/iser_memory.o LD [M] drivers/infiniband/hw/nes/iw_nes.o CC [M] drivers/infiniband/ulp/iser/iscsi_iser.o LD [M] drivers/infiniband/hw/ipath/ib_ipath.o CC [M] drivers/infiniband/ulp/srp/ib_srp.o CC [M] drivers/infiniband/ulp/ipoib/ipoib_ib.o CC [M] drivers/infiniband/ulp/ipoib/ipoib_multicast.o CC [M] drivers/infiniband/ulp/ipoib/ipoib_verbs.o CC [M] drivers/infiniband/ulp/ipoib/ipoib_vlan.o LD [M] drivers/infiniband/ulp/iser/ib_iser.o CC [M] drivers/infiniband/ulp/ipoib/ipoib_ethtool.o CC [M] drivers/infiniband/ulp/ipoib/ipoib_netlink.o CC [M] drivers/infiniband/ulp/ipoib/ipoib_cm.o CC [M] drivers/infiniband/ulp/ipoib/ipoib_fs.o LD [M] drivers/infiniband/ulp/ipoib/ib_ipoib.o make: *** [drivers] Error 2 The last few line preceeding the "make: *** [drivers] Error 2" line are for a different make subprocess that didn't fail. After the compile failure, run make again with -j1 and then paste error again. #make -j1 modules
CHK include/config/kernel.release
CHK include/generated/uapi/linux/version.h
CHK include/generated/utsrelease.h
CHK include/generated/bounds.h
CHK include/generated/asm-offsets.h
CALL scripts/checksyscalls.sh
LD [M] drivers/gpu/drm/drm_kms_helper.o
LD [M] drivers/gpu/drm/drm.o
CC [M] drivers/gpu/drm/i915/intel_dp.o
drivers/gpu/drm/i915/intel_dp.c:1924:9: error: expected declaration specifiers or ‘...’ before ‘&’ token
memset(&pipe_config->dpll_hw_state, 0,
^
drivers/gpu/drm/i915/intel_dp.c:1924:38: error: expected declaration specifiers or ‘...’ before numeric constant
memset(&pipe_config->dpll_hw_state, 0,
^
drivers/gpu/drm/i915/intel_dp.c:1925:9: error: expected declaration specifiers or ‘...’ before ‘sizeof’
sizeof(pipe_config->dpll_hw_state));
^
make[4]: *** [drivers/gpu/drm/i915/intel_dp.o] Error 1
make[3]: *** [drivers/gpu/drm/i915] Error 2
make[2]: *** [drivers/gpu/drm] Error 2
make[1]: *** [drivers/gpu] Error 2
make: *** [drivers] Error 2
This looks really odd. Can you attach the file drivers/gpu/drm/i915/intel_dp.c you get after applying the patch? In any case, the patch is now in nightly, so please try that. commit d971d68ab45fb21866afa264ed5881e789b7e191 Author: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com> Date: Fri May 15 13:34:29 2015 +0300 drm/i915: Don't overwrite (e)DP PLL selection on SKL Test it on the latest nightly kernel, this problem does not exists. So verified. Closing verified+fixed. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.