Bug 103879 - The user named "operator" could not be displayed in the gdm face browser
Summary: The user named "operator" could not be displayed in the gdm face browser
Status: RESOLVED FIXED
Alias: None
Product: accountsservice
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Matthias Clasen
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-24 07:16 UTC by qzheng
Modified: 2017-12-08 15:21 UTC (History)
5 users (show)

See Also:
i915 platform:
i915 features:


Attachments
Just may be - can we consider to clean up the blacklist in Accountsservice (users like: operator, noaccess, nobody4 seem not used) (383 bytes, patch)
2017-11-24 07:25 UTC, qzheng
Details | Splinter Review

Description qzheng 2017-11-24 07:16:07 UTC
The original bug was reported by Hans van den Heuvel on the SUSE bugzilla:

Environment:
- SLES12 SP2
- SLES12 SP3

Problem :
I am not yet sure if this qualifies as a bug, or is WAD.

Customer is looking for a way to display a user named 'operator' on the GDM face browser.
This does not appear to be possible.

Expected results :
We should be able to also display 'system' users  on the GDM face browser


What was tried :
[1] The only mention of operator can be found in the gdm manual:
	for i in $(rpm -ql gdm); do grep -ri operator $i; done

 In /usr/share/help/C/gdm/index.docbook

we state :
         <varlistentry>
            <term>Exclude</term>
            <listitem>
              <synopsis>Exclude=bin,root,daemon,adm,lp,sync,shutdown,halt,mail,news,uucp,operator,nobody,nobody4,noaccess,postgres,pvm,rpm,nfsnobody,pcap</synopsis>
              <para>
                Set to a list of users to always exclude in the Face Browser.
                This value is set to a list of users separated by commas.  Note
                that the setting in the <filename>custom.conf</filename>
                overrides the default value, so if you wish to add additional
                users to the list, then you need to set the value to the
                default value with additional users appended to the list.
              </para>
            </listitem>
          </varlistentry>
        </variablelist>
 
using this, overrride should function when we edit '/etc/gdm/custom.conf' with the following, but it does not. :

	$ cat /etc/gdm/custom.conf
	# GDM configuration storage
	#
	# Note: settings from /etc/sysconfig/displaymanager have a higher priority
	#
	[daemon]
	[security]
	[xdmcp]
	[greeter]
	Include=operator
	[chooser]
 

	linux-jaal:/var/lib/AccountsService/users # cat operator
	[User]
	Language=en_US.UTF-8
	XSession=
	SystemAccount=false
 

[2]  Using "IncludeAll=true" also has no effect :

	linux-jaal:/var/lib/AccountsService/users # cat /etc/gdm/custom.conf
	# GDM configuration storage
	#
	# Note: settings from /etc/sysconfig/displaymanager have a higher priority
	#
	[daemon]
	[security]
	[xdmcp]
	[greeter]
	IncludeAll=true
	[chooser]
	[debug]

[3] Tried creating /var/lib/AccountsService/users/operator and set SystemAccount to false.
Comment 1 qzheng 2017-11-24 07:25:20 UTC
Created attachment 135692 [details] [review]
Just may be - can we consider to clean up the blacklist in Accountsservice (users like: operator, noaccess, nobody4 seem not used)
Comment 2 Ray Strode [halfline] 2017-12-08 15:19:19 UTC
well, i don't think operator is actually used for anything in practice, but it is created by default (on fedora at least) with a system uid.

I guess it's going to get pruned anyway though, since it's got a system uid, so i'm okay with dropping it from the blacklist.
Comment 3 Ray Strode [halfline] 2017-12-08 15:21:59 UTC
attachment 135692 [details] [review] pushed as ca3199f:

To ssh://git.freedesktop.org/git/accountsservice
   dcc6e3f..ca3199f  master -> master


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.