Bug 104267 - fbdev fails to resume if screen is rotated
Summary: fbdev fails to resume if screen is rotated
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/fbdev (show other bugs)
Version: git
Hardware: Other Linux (All)
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
Depends on:
Reported: 2017-12-14 16:46 UTC by Michael Tretter
Modified: 2018-08-10 20:41 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

0001-fbdev-do-not-update-virtual-size-of-pScrn-when-rotat.patch (2.59 KB, patch)
2017-12-14 16:46 UTC, Michael Tretter
no flags Details | Splinter Review

Description Michael Tretter 2017-12-14 16:46:25 UTC
Created attachment 136176 [details] [review]

I am using the fbdev driver for a rotated display with the following device section:

   Section "Device"            
       Identifier "fbdev"   
       Driver "fbdev"       
       Option "Rotate" "CCW"

The screen is properly rotated after a normal boot, but after hibernating and resuming the system, X fails with the following error message:

(EE) FBDEV(0): FBIOPUT_VSCREENINFO: Invalid argument
Fatal server error:
(EE) EnterVT failed for screen 0
Please consult the The X.Org Foundation support 
	 at http://wiki.x.org
 for help. 
(EE) Please also check the log file at "/var/log/Xorg.0.log" for additional information.
(EE) Server terminated with error (1). Closing log file.

The error happens during EnterVT() in the fbdevHWSetMode() function, which reads the virtual size from the ScrnInfo, but the fbdev driver updated the virtualX and virtualY after the initial modeset with the X and Y for the rotated screen.

The attached patch removes the update of these fields and switches to temporary variables for width and height as it was done before commit 43236f5b ("Fix shadow framebuffer, and by extension rotation.").
Comment 1 GitLab Migration User 2018-08-10 20:41:52 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/xorg/driver/xf86-video-fbdev/issues/7.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.