Bug 104644 - Implement randr 1.2 hooks for xwayland
Summary: Implement randr 1.2 hooks for xwayland
Status: RESOLVED MOVED
Alias: None
Product: Wayland
Classification: Unclassified
Component: XWayland (show other bugs)
Version: unspecified
Hardware: Other All
: medium enhancement
Assignee: Robert Mader
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on: 104686
Blocks: 104643
  Show dependency treegraph
 
Reported: 2018-01-15 16:37 UTC by Robert Mader
Modified: 2019-05-10 15:53 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
use RandR 1.2 interface and enable mode setting (3.31 KB, patch)
2018-01-18 15:09 UTC, Robert Mader
Details | Splinter Review

Description Robert Mader 2018-01-15 16:37:42 UTC
To make it possible for xwayland to fake mode setting to clients, we shouldn't use the legacy randr 1.0 api as it doesn't allow us to differentiate between xwl_outputs.
We should use randr 1.2 hooks instead, which provide that functionality.
Comment 1 Robert Mader 2018-01-18 15:09:35 UTC
Created attachment 136831 [details] [review]
use RandR 1.2 interface and enable mode setting

This adds the RandR 1.2 interface to xwayland and allows modes
advertised by the compositor to be set.

RandR 1.2 will be needed to implement fake-mode-setting.

As RandR 1.2 does not allow to set unregistered modes and xwayland
only lists those send by the compositor, it's save to enable mode-
setting already, as only compositors which send multiple modes
are affected.
Compositors should only send multiple modes if they can handle
the resulting behaviour.
Comment 2 Robert Mader 2018-01-18 15:10:45 UTC
(In reply to Robert Mader from comment #1)
> Created attachment 136831 [details] [review] [review]
> use RandR 1.2 interface and enable mode setting
> 
> This adds the RandR 1.2 interface to xwayland and allows modes
> advertised by the compositor to be set.
> 
> RandR 1.2 will be needed to implement fake-mode-setting.
> 
> As RandR 1.2 does not allow to set unregistered modes and xwayland
> only lists those send by the compositor, it's save to enable mode-
> setting already, as only compositors which send multiple modes
> are affected.
> Compositors should only send multiple modes if they can handle
> the resulting behaviour.

I forgot to mention: this depends on https://patchwork.freedesktop.org/patch/191035/
Comment 3 GitLab Migration User 2019-05-10 15:53:19 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/xorg/xserver/issues/712.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.