Bug 106578 - RedShift: xf86-video-amdgpu + amdgpu.dc=1 seems to apply gamma adjustment twice to the mouse cursor
Summary: RedShift: xf86-video-amdgpu + amdgpu.dc=1 seems to apply gamma adjustment twi...
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/AMDgpu (show other bugs)
Version: git
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: xf86-video-ati maintainers
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-19 13:10 UTC by tempel.julian
Modified: 2018-07-04 14:16 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description tempel.julian 2018-05-19 13:10:34 UTC
When using xf86-video-amdgpu + amdgpu.dc=1 at the same time, enabling RedShift makes the mouse cursor appear too orange/dark. It looks like if the gamma adjustment is applied twice instead of once.

When using xf86-video-amdgpu + amdgpu.dc=0, the cursor looks correct (as orange as the rest of the screen).

When using amdgpu.dc=1 with modesetting DDX instead of xf86-video-amdgpu, the cursor looks correct as well.

(And for the sake of completeness: amdgpu.dc=0 without xf86-video-amdgpu leaves the mouse cursor completely untouched by RedShift.)

Best set your mouse cursor skin to something white, e.g. "DMZ White".

drm-next-4.18-wip (latest commit: 404af8e5236fe7eb64d91bf708bd7aa81815d14e) with Xorg 1.20 and xf86-video-amdgpu 18.0.1.
Comment 1 Michel Dänzer 2018-05-22 09:51:12 UTC
Harry, since when does DC apply the gamma LUT to the HW cursor as well? How can xf86-video-amdgpu check for this?
Comment 2 Michel Dänzer 2018-06-26 16:43:58 UTC
https://patchwork.freedesktop.org/patch/232244/ should fix this.
Comment 3 tempel.julian 2018-06-26 17:42:03 UTC
Thanks, I'll gladly try it out once this bug is fixed as well as I'll first have to install my RX 560 again:
https://bugs.freedesktop.org/show_bug.cgi?id=106175
Comment 4 Michel Dänzer 2018-07-04 14:16:24 UTC
Thanks for the report, should be fixed in Git master:

commit 8e98195e58f77fd1f354b2707360bd4445aef5b4
Author: Michel Dänzer <michel.daenzer@amd.com>
Date:   Tue Jun 26 18:40:23 2018 +0200

    Don't apply gamma to HW cursor data if colour management is enabled


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.