Bug 106588 - [xserver 1.20.0] Xorg.wrap broken - meson build
Summary: [xserver 1.20.0] Xorg.wrap broken - meson build
Status: RESOLVED MOVED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: unspecified
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2018-05-20 16:10 UTC by Darek
Modified: 2018-12-13 22:39 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
Fix bug#1 and #2 (1.63 KB, patch)
2018-05-20 16:10 UTC, Darek
no flags Details | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Darek 2018-05-20 16:10:18 UTC
Created attachment 139652 [details] [review]
Fix bug#1 and #2

Related: https://bugs.archlinux.org/task/58644

/usr/bin/Xorg In xorg-server 1.20.0 is no longer a wrapper script.
Instead it's a binary that appears to be identical to the one at /usr/lib/Xorg .
This breaks the execution of X with root rights.

summary:
#1
'Xorg'[1] and 'Xorg'[2] are generated in the same build meson directory. One overwrites the other

#2
meson does not apply install_mode for executable targets so the suid is not set infact the meson.build does not even try to set it.

[1] https://cgit.freedesktop.org/xorg/xserver/tree/hw/xfree86/meson.build?h=xorg-server-1.20.0#n101
[2] https://cgit.freedesktop.org/xorg/xserver/tree/hw/xfree86/meson.build?h=xorg-server-1.20.0#n148
Comment 1 Darek 2018-07-22 19:23:50 UTC
summary #2: https://github.com/mesonbuild/meson/issues/3328
Comment 2 GitLab Migration User 2018-12-13 22:39:45 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/xorg/xserver/issues/539.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.